Repository navigation
Conversation
The blvm CLI Network enum (src/bin/main.rs) accepts regtest, testnet, signet, testnet4 and mainnet, but the network tables only listed three. Add --network values and default P2P/RPC ports from blvm::default_p2p_port_for_network / default_rpc_addr_for_network, magic bytes from blvm-protocol network_params, REST and assume-valid defaults from blvm-node. Also correct the unset-listen_addr P2P default to loopback (127.0.0.1), which is what main.rs binds, and drop the stale 'Signet is not yet supported' note.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Document every network the
blvmCLI accepts. The tables listed mainnet, testnet3 and regtest only;--networkalso takessignetandtestnet4.getting-started/first-node.mdandnode/configuration.mdnetwork tables: new--networkcolumn, plus Signet and Testnet4 rows.protocol/overview.md: Signet (0f1bf2e1) and Testnet4 (1c163f28) rows with magic bytes and ports.listen_addris set by CLI, env or config file,blvmbinds127.0.0.1:<port>, not0.0.0.0(src/bin/main.rs:968). Added a one-line note on setting0.0.0.0:<port>for inbound peers.Why
The CLI's
Networkenum (blvmsrc/bin/main.rs:324) has had Signet and Testnet4 for a while, but the docs still describe three networks.Sources (from code)
#[derive(ValueEnum)] enum Network { Regtest, Testnet, Signet, Testnet4, Mainnet }blvm::default_p2p_port_for_network/default_rpc_addr_for_network(src/lib.rs). Signet 38333/38332, Testnet4 48333/48332.network_params.rsconfig/mod.rsVerified
./scripts/verify-book-inputs.shOK.mdbook build(v0.4.43 + mdbook-governance-vars) exits 0 with no ERROR/WARN lines.Note: signet's derived REST port (48332) is the same as testnet4's default RPC port. That only matters when both run on one host.