Repository navigation
chore: sync version with crates.io (0.1.73) and commit Release version bump - #27
Merged
Merged
Conversation
…ersion bump Release published up to 0.1.73 with --allow-dirty and never committed the [package] version bump, so main stayed at 0.1.13. Set main to the crates.io max and add a Release step (after a successful publish) that commits only the [package] version line as 'Bump version to X for release [skip ci]', matching blvm-consensus.
The previous commit message quoted the release skip marker, which made GitHub skip the pull_request workflows for that head.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainsays0.1.13but crates.io hasblvm-node0.1.73. This PR fixesmainand makes Release commit its version bump from now on, the way blvm-consensus already does.Evidence
main@ 8f4aba5:Cargo.toml[package] version = "0.1.13".max_version0.1.73, tagv0.1.73.--allow-dirty, but never committed the change.Bump version to X for release [skip ci]from Release (e.g. 1cf24e4, 0.1.61, matches crates.io).Changes
Cargo.toml:[package] version0.1.13 → 0.1.73. No other change;Cargo.lockis gitignored. No other in-repo references to 0.1.13.ci.ymlRelease: new step Commit Cargo.toml version bump, placed after Publish to crates.io and before the tag step.steps.publish.outputs.published == 'true'.HEAD:${{ github.ref }}withREPO_ACCESS_TOKEN(|| true, as consensus does).[package] versionline. It applies the same awk toHEAD:Cargo.tomland stages that blob withgit update-index.Cargo.tomlon disk also has the stripped[patch.crates-io]and theblvm-protocol = "<crates.io ver>"rewrite. Consensus's whole-filegit adddid land its patch-section strip on main in 1cf24e4.Run locally
cargo metadata --no-depsresolves version 0.1.73. A full localcargo check -j 2could not build on this box:openssl-sysneeds pkg-config, andtikv-jemalloc-sysneedsmake, neither of which is installed. No Rust source changed, so CI is the build check.Cargo.toml. The commit had a one-line version diff, and the working tree was left as it was.