Repository navigation
chore: sync sdk + macros versions with crates.io (0.1.19) and commit Release version bump - #6
Merged
Merged
Conversation
….19); commit Release version bump Release published both crates up to 0.1.19 with --allow-dirty and never committed the [package] version bumps, so main stayed at 0.1.13 (sdk) and 0.1.0 (macros). Set both to the crates.io max. Add a Release step after both publishes, before the tag, that commits only the two [package] version lines (Bump version to X for release, with the skip-ci marker, as blvm-consensus does). The release-time pins of blvm-sdk-macros and blvm-node and the stripped patch section stay off main, which keeps the path dep. A failed push to main is reported as a workflow warning and step-summary entry instead of being ignored, without failing after publish. A failed tag push now prints the manual tag command at the release commit (the bump commit when present).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does for blvm-sdk what blvm-node#27 / blvm-protocol#7 do:
main's manifests lag crates.io because Release publishes with--allow-dirtyand never commits its version bump.Evidence
main@ d3000d8 (== tagv0.1.19): rootCargo.tomlversion = "0.1.13";crates/blvm-sdk-macros/Cargo.tomlversion = "0.1.0".max_version: blvm-sdk 0.1.19, blvm-sdk-macros 0.1.19.Changes
[package] versionlines → 0.1.19. The root'sblvm-sdk-macros = { path = "crates/blvm-sdk-macros" }stays a path dep on main.Cargo.lockis gitignored. No other in-repo references to the old versions.ci.ymlRelease: new step Commit Cargo.toml version bumps, after Publish blvm-sdk and before Verify published crates / the tag step.publish_macrosandpublish_sdkreportpublished == 'true'.Bump version to X for releasewith the skip-ci marker (consensus's format).[package] versionlines: it applies the job's own awk toHEAD:<manifest>and stages the result withgit update-index.blvm-sdk-macros = { version = "=X", path = … }andblvm-node = "<max>", and the strip action removes[patch.crates-io]. None of that is committed. The on-disk release manifests that publish uses aren't touched.contents: write;mainis unprotected), the same one the tag push uses. Pushes made with GITHUB_TOKEN don't trigger workflows.::warningannotation and a step-summary section with the unpushed commit and what to do. It doesn't fail the job, because both crates are already published and the tag / GitHub Release still need to run.git rev-parse HEAD, i.e. the bump commit when present). It still exits 1, as before.Run locally
cargo metadata: blvm-sdk 0.1.19, and blvm-sdk-macros 0.1.19 resolved via the path dep.cargo check -j 2incrates/blvm-sdk-macros: pass.cargo check -j 2 --no-default-features --libon the root: pass.A full default-features
cargo checkcouldn't build on this box:tikv-jemalloc-sysneedsmake, which isn't installed. CI is the full build check.actionlint shows no new findings compared with
main, and the YAML step order was checked.The bump logic was run in a scratch clone against release-style manifests (version bump,
=0.1.20macros pin, stripped patch section). The commit had exactly two one-line version diffs, and the working tree was left as it was.Also bumps the
wasmtimepin from=36.0.18to=36.0.19(Cargo.toml:66) for RUSTSEC-2026-0379 and 0380 (critical Cranelift miscompilations, published 2026-10-19), whichcargo auditin downstream blvm CI now rejects.