Repository navigation
ci(lock): check out pinned consensus + primitives next to spec-lock for the lock tests - #3
Open
secsovereign wants to merge 3 commits into
Open
secsovereign wants to merge 3 commits into
secsovereign wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main is red at 6382e2c (run 40022891446, zeus-workstation-2): 67 of 139 lib tests panic with ENOENT because
production_lockreads../blvm-consensus/src/...and../blvm-primitives/src/..., and the Test job only checks out spec-lock. The earlier green at 3a55aeb ran on zeus-workstation, which already had ablvm-consensusdir next to the workspace, so it read whatever leftover sources were on disk.This makes the Test job check out spec-lock into
blvm-spec-lock/, with blvm-consensus pinned at 994480d (v0.1.70 main) and blvm-primitives pinned at 9720541 (0.1.30 main) beside it. Nothing skips: missing sources still fail the job.Locally with that layout (rust 1.88.0,
cargo test --workspace --all-features --no-fail-fast), the 67 lock failures are gone. One CI failure is left, and this PR doesn't fix it:published_gate_matches_the_table(new in 6382e2c) also reads../docs/FORMAL_VERIFICATION_PLAN.mdand../docs/README.md. I can't find that file in any BTCDecoded repo, so it needs that docs tree pushed somewhere CI can check out.Box-only noise, not CI:
u64_shl_wraps_when_the_top_bit_is_setreturns Unknown on my machine (it passes in CI), and the extract_* integration tests failed only because I used a custom CARGO_TARGET_DIR.