Repository navigation
Header: Console Live only when the status check passes; human chain labels + chain on Home - #3
Open
secsovereign wants to merge 1 commit into
Open
secsovereign wants to merge 1 commit into
secsovereign wants to merge 1 commit into
Conversation
… every page; chain labels say Mainnet/Testnet3, not main/test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes UI UX's Commons UI audit P1-1 ("Console Live" always shown) and the chain-label items (P1-3, P3-1).
Console Live
ui.livestartstruebefore any check has run./api/statushas answered (settled && ui.live). If the check fails, it reads "Console offline, retrying…" with a red light. Before the first answer, nothing shows. The text is in arole="status"span, so the state no longer depends on colour alone. The Umbrel "Node agent offline" branch is unchanged.Chain labels
chainLabel()innetworks.tsmaps the RPC chain to the label the wizard already uses:main→ Mainnet,test→ Testnet3,testnet4→ Testnet4,signet,regtest. It's used on the Insights chip, the Network panel chip, Settings → About "Chain", the "node is running but RPC is not answering" sentence, and the unusedNodePanel. Before, these showed rawmain/test.1.2.3.4:48333(the testnet4 port) on every chain. They now use the P2P port of the chain the node is on, or 8333 if the chain is unknown.No node or consensus code touched; web only.
Tests
The repo has no test runner.
npm ci,vite buildandtsc --noEmitpass.Smoke in headless Chrome:
mock/server.mjs, the header shows the "Mainnet" chip and "Console Live".dist/served with no API, the header shows "Console offline, retrying…" and no chain chip.Live recheck: on an Umbrel or local install, the header shows the right chain chip ("Testnet3" on the Umbrel BLVM Node app) and "Console Live". Stop the console host or block
/api/status, and within a few seconds the header switches to "Console offline, retrying…".Donate: n/a (no donate flow in this app).
@review default scope. @ui UX