Conversation
There are no breaking changes in upgrading our pytest base, as far as I can tell, and all tests appear to be unchanged before and after (aside from a few bugs that have apparently occured over time as changes have been made that I fixed). This fixes a few minor issues, and prevents the deprecation warnings that are starting to pop up in Python 3.14 with the previous pytest version. Signed-off-by: Ethan Dye <mrtops03@gmail.com>
byubean
reviewed
Nov 18, 2025
|
|
||
|
|
||
| @dialog(test_files / 'test_cached_asset.dialog.txt', python_script) | ||
| @dialog(test_files / 'test_cached_asset.dialog.txt', python_script()) |
There was a problem hiding this comment.
What was the motivation behind this change?
Member
Author
There was a problem hiding this comment.
It was using improper syntax for the dialog function. Unless you call it before passing, it will throw an error because dialog is expecting a Path not a Callable. Until I changed it, both before and after I upgraded the base version, it would throw an error.
byubean
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are no breaking changes in upgrading our pytest base, as far as I can tell, and all tests appear to be unchanged before and after (aside from a few bugs that have apparently occured over time as changes have been made that I fixed).
This fixes a few minor issues, and prevents the deprecation warnings that are starting to pop up in Python 3.14 with the previous pytest version.