Repository navigation
Update Release Workflows, Merge CI and CD Workflows - #1043
Conversation
|
Since this workflow uses OIDC, the Trusted Publisher configuration must be updated on PyPI |
|
Thank you for the contributions. I noticed two issues:
|
Not entirely. It still provides a source distribution, so users can install via pip and build from source. It only drops prebuilt wheel releases.
Since Python 3.8/3.9 has reached EOL, I removed CI/CD support for it. Tests are preserved for all wheels from Python 3.10 through 3.14 |
I didn't find an x86_64 wheel for macOS here PyPI |
Sorry, I accidentally dropped the commit that added Python 3.14 support during a rebase. It has now been restored, and both Python 3.14 and 3.14t are supported |
|
I see. The release-pypi-macos.sh script now supports both arm64 and x86_64 depending on the runner architecture, but in CI we currently only execute it on macos-14, which is arm64. As a result, only arm64 wheels are being produced. To generate x86_64 wheels as well, we would need to run the job on an Intel runner (e.g., macos-13). This is outside the scope of this PR. |
|
@XXXXRT666 I am a bit concerned about this change, because by removing the manual release scripts, we will have to depend on Github's workflow to release a new version to PyPi. |
Building against lower glibc requires Docker, which is quite heavy for a simple script With GitHub Actions, we still keep manual triggering, and the workflow will stop before publishing if build or tests fail, so nothing will be pushed to PyPI in that case. Also, the workflow runs on all PRs as checks. The artifacts contain the built wheels — if needed, we can download them and upload to PyPI manually. |
|
It also looks like the current wheels are already being built via GitHub Actions? The macos-14 runner is arm64 so it conflicts with |
|
Can you please update the PR to be a more focused change:
We can hopefully do a 1.3.1 maintenance release once your update is merged. Thanks! |
54569be to
0d88dc5
Compare
|
Done, drop conda, use Since we cannot easily change the glibc version using conda, I removed conda and switched to using |
Updated `release-pypi-linux.sh` to build source distribution and upload all files from the wheelhouse. Build `sdist` only once in Linux x86_64 architecture, to avoid duplicate uploads from matrix jobs.
|
https://pypi.org/project/OpenCC/1.3.1/ is successfully publish. Thank you for your contributions, @XXXXRT666 ! |

The previous release (e.g., opencc-1.2.0-cp311-cp311-manylinux2014_x86_64.whl) is tagged as manylinux2014, however, the actual glibc requirement is 2.33.
This workflow have been tested on TestPyPI
Related Issues: #913 #892 #832 #424 #420 #419 GPT-SoVITS#1513
GLIBC Requirements