Skip to content

Fix Mariana and soap conversion errors in STPhrases.txt (sorted) - #1052

Merged
BYVoid merged 1 commit into
masterfrom
claude/review-opencc-sorting-Xveam
Mar 17, 2026
Merged

BYVoid merged 1 commit into
masterfrom
claude/review-opencc-sorting-Xveam

Conversation

@BYVoid

@BYVoid BYVoid commented Mar 17, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Apply dictionary corrections from 修正"馬里亞納"與"肥皂"相關轉換錯誤 #1048 with proper sorting via data/scripts/sort.py
  • Fix 北马里亚纳 value missing traditional character 馬
  • Fix 马里亚纳海沟 value using incorrect character 裏 instead of 里
  • Swap 4 soap-related entries (肥皂劇/肥皂絲/肥皂莢/軟肥皂) to correct simplified→traditional key-value direction

Ref: #1048

Test plan

  • Ran data/scripts/sort.py on STPhrases.txt
  • Verified idempotency (running sort again produces no diff)

Apply changes from PR #1048 and run sort script to ensure proper ordering.
Fixes: 北马里亚纳 value missing 馬, 马里亚纳海沟 using wrong 裏 character,
and four soap-related entries (肥皂劇/肥皂絲/肥皂莢/軟肥皂) that had
reversed key-value direction.

https://claude.ai/code/session_01T5mBvwfj1Wb622xrh6Fgwv
@BYVoid
BYVoid merged commit 908bd03 into master Mar 17, 2026
33 of 34 checks passed
@frankslin
frankslin deleted the claude/review-opencc-sorting-Xveam branch April 19, 2026 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants