Repository navigation
Return non-zero exit code on conversion failure - #1072
Merged
Merged
Conversation
When opencc or opencc_dict encounters an error (e.g. config file not found), the process now exits with code 1 instead of 0. This allows shell scripts and other tools to detect conversion failures. Fixes #969 https://claude.ai/code/session_019NsFdBhXY59ogGvvMQCHN8
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openccoropencc_dictencounters an error (e.g. config file not found), the process now exits with code 1 instead of always returning 0.$?.Test plan
opencc -i /dev/null -c gg.jsonnow returns exit code 1openccandopencc_dictsuccessfullyFixes #969