Repository navigation
Keep Darts support always enabled - #1374
Merged
Merged
Conversation
Add resource zip loading for legacy OCD dictionaries and remove the obsolete opencc_config feature header now that Darts support is mandatory. Detailed Changes: - **OCD Resource Zip Loading:** - Load .ocd dictionaries directly from ResourceProvider buffers. - Share parsing with the existing 32-bit and legacy 64-bit Darts readers. - **Mandatory Darts Support:** - Remove ENABLE_DARTS guards so ocd conversion and loading are always available. - Drop USE_SYSTEM_DARTS because the vendored darts-clone copy has OpenCC-specific fixes, and system Darts versions are likely to expose incompatible interfaces or data sizing. - **Config Header Cleanup:** - Delete the obsolete opencc_config headers and remove them from CMake, Bazel, and npm packaging lists.
Add DartsDict and the vendored darts-clone include tree to the node-gyp and Zig Windows addon build inputs so Config and DictConverter can resolve mandatory OCD support symbols.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add resource zip loading for legacy OCD dictionaries and remove the obsolete opencc_config feature header now that Darts support is mandatory.
Detailed Changes:
OCD Resource Zip Loading:
Load .ocd dictionaries directly from ResourceProvider buffers.
Share parsing with the existing 32-bit and legacy 64-bit Darts readers.
Mandatory Darts Support:
Remove ENABLE_DARTS guards so ocd conversion and loading are always available.
Drop USE_SYSTEM_DARTS because the vendored darts-clone copy has OpenCC-specific fixes, and system Darts versions are likely to expose incompatible interfaces or data sizing.
Config Header Cleanup: