Repository navigation
Import darts-clone 0.32h from BCR with OpenCC patch - #1386
Merged
Merged
Conversation
frankslin
marked this pull request as draft
July 2, 2026 07:04
Replace local_path_override with the BCR module and a single_version_override patch that captures the three local modifications: BUILD filegroup target, rules_cc 0.2.20, and the darts.h changes (uint32_t id_type, copy_array, validate).
frankslin
marked this pull request as ready for review
July 2, 2026 07:10
- Keep unsigned int id_type unsigned int is 32-bit on every supported target, so matching upstream exactly avoids a gratuitous divergence. Also drop the MODULE.bazel docstring change that added no functional value. - Drop docstring edit - Drop unused all_files filegroup from darts-clone patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
darts-clonefromlocal_path_overrideto the BCR module at0.32hpatches/darts-clone-opencc.patch(single_version_override,patch_strip = 1) coveringthree local modifications:
BUILD.bazel: addall_filesfilegroupMODULE.bazel: shorten docstring; bumprules_ccto0.2.20include/darts.h:uint32_t id_type,copy_array(),validate()deps/darts-clone-0.32h/stays in-tree as reference; no behaviour changeTest plan
bazel build //...greenbazel test //...green