Repository navigation
Honor legacy Python executable CMake option - #1389
Merged
Merged
Conversation
Map PYTHON_EXECUTABLE to Python3_EXECUTABLE before locating Python so existing packaging scripts continue to select the intended interpreter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Map PYTHON_EXECUTABLE to Python3_EXECUTABLE before locating Python so existing packaging scripts continue to select the intended interpreter.
data/CMakeLists.txt 目前已經改用 CMake 的 FindPython3，實際使用的是 Python3_EXECUTABLE；但不少既有 packaging 腳本和舊 CMake 慣例仍傳 PYTHON_EXECUTABLE。如果不作映射，CMake 會忽略這個變數、發出 unused warning，並可能選到另一個非預期的 Python interpreter。OpenCC 的 dictionary generation scripts 依賴 Python，所以此 interpreter selection 應該可控。
Homebrew formula 即一個實例：
https://github.com/Homebrew/homebrew-core/blob/903002c316be3210924e1c11859275e28b0cc309/Formula/o/opencc.rb#L26