Skip to content

Fix 黄梁美梦 conversion: 黃樑美夢 → 黃梁美夢 - #1408

Merged
frankslin merged 1 commit into
masterfrom
copilot/fix-huangliangmeimeng-conversion
Jul 8, 2026
Merged

frankslin merged 1 commit into
masterfrom
copilot/fix-huangliangmeimeng-conversion

Conversation

@frankslin

Copy link
Copy Markdown
Collaborator

The existing STPhrases.txt entry incorrectly mapped 黄梁美梦 to 黃樑美夢. The compound 梁 in this idiom should not be converted to 樑; corrected to 黃梁美夢, consistent with the adjacent entries 黄梁 → 黃梁 and 黄梁梦 → 黃梁夢.

Found by @LeeiFrankJaw in #1407.

The existing STPhrases.txt entry incorrectly mapped 黄梁美梦 to 黃樑美夢.
The compound 梁 in this idiom should not be converted to 樑; corrected to 黃梁美夢,
consistent with the adjacent entries 黄梁 → 黃梁 and 黄梁梦 → 黃梁夢.
@frankslin
frankslin merged commit 3a3f7e9 into master Jul 8, 2026
39 of 41 checks passed
@frankslin
frankslin deleted the copilot/fix-huangliangmeimeng-conversion branch July 8, 2026 04:21
@LeeiFrankJaw

LeeiFrankJaw commented Jul 8, 2026 •

Copy link
Copy Markdown
Contributor

Well, I suppose 黄梁 should be 黄粱. It was a kind of staple food in the past. The bottom radical is 米 instead of 木. I never found 黄梁一梦 (黃梁一夢) in either mainland dictionaries or Taiwan dictionaries.

And this also implies the fact that these phrases should not occur in the file STPhrases.txt.

@frankslin

Copy link
Copy Markdown
Collaborator Author

Well, I suppose 黄梁 should be 黄粱. It was a kind of staple food in the past. The bottom radical is 米 instead of 木. I never found 黄梁一梦 (黃梁一夢) in neither mainland dictionaries or Taiwan dictionaries.

And this also implies the fact that these phrases should not occur in the file STPhrases.txt.

Fixed in #1410.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants