Repository navigation
Fix 黄梁美梦 conversion: 黃樑美夢 → 黃梁美夢 - #1408
Merged
Merged
Conversation
The existing STPhrases.txt entry incorrectly mapped 黄梁美梦 to 黃樑美夢. The compound 梁 in this idiom should not be converted to 樑; corrected to 黃梁美夢, consistent with the adjacent entries 黄梁 → 黃梁 and 黄梁梦 → 黃梁夢.
Contributor
|
Well, I suppose 黄梁 should be 黄粱. It was a kind of staple food in the past. The bottom radical is 米 instead of 木. I never found 黄梁一梦 (黃梁一夢) in either mainland dictionaries or Taiwan dictionaries. And this also implies the fact that these phrases should not occur in the file STPhrases.txt. |
Collaborator
Author
Fixed in #1410. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing STPhrases.txt entry incorrectly mapped 黄梁美梦 to 黃樑美夢. The compound 梁 in this idiom should not be converted to 樑; corrected to 黃梁美夢, consistent with the adjacent entries 黄梁 → 黃梁 and 黄梁梦 → 黃梁夢.
Found by @LeeiFrankJaw in #1407.