Repository navigation
Enable the Jieba plugin by default for top-level macOS CMake builds - #1419
Merged
Merged
Conversation
Homebrew builds opencc with default CMake options and formula options are not allowed in homebrew-core, so flipping the BUILD_OPENCC_JIEBA_PLUGIN default to ON for top-level Apple builds ships the plugin, the merged Jieba dictionary, and the *_jieba.json configs to Homebrew users on the next formula version bump without any formula change. Subproject builds (FetchContent / add_subdirectory, e.g. librime) and non-Apple platforms keep the OFF default, and setup.py now disables the plugin explicitly so macOS Python wheels do not grow by the ~18MB Jieba dictionaries. Verified a Homebrew-style default build installs the plugin and that the installed opencc converts with s2twp_jieba.json; macOS CI (make build / make test) now also covers the plugin by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Homebrew builds opencc with default CMake options and formula options are not allowed in homebrew-core, so flipping the BUILD_OPENCC_JIEBA_PLUGIN default to ON for top-level Apple builds ships the plugin, the merged Jieba dictionary, and the *_jieba.json configs to Homebrew users on the next formula version bump without any formula change.
Subproject builds (FetchContent / add_subdirectory, e.g. librime) and non-Apple platforms keep the OFF default, and setup.py now disables the plugin explicitly so macOS Python wheels do not grow by the ~18MB Jieba dictionaries. Verified a Homebrew-style default build installs the plugin and that the installed opencc converts with s2twp_jieba.json; macOS CI (make build / make test) now also covers the plugin by default.