Repository navigation
s2t: align 惊叹/赞叹/咏叹 etc. to 嘆 per 國語辭典 (#641) - #1451
Closed
stantheman0128 wants to merge 1 commit into
Closed
stantheman0128 wants to merge 1 commit into
stantheman0128 wants to merge 1 commit into
Conversation
STCharacters already prefers 嘆, but several STPhrases rows still forced 歎 on the issue's disputed forms. Update those rows and direct compounds only; keep literary 歎 entries the issue already agrees on. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #641.
Problem
STCharacters.txtalready prefers叹 -> 嘆 歎, and many related phrases already map to嘆, but severalSTPhrases.txtrows still force歎. That leaves OpenCC inconsistent with 《重編國語辭典修訂本》 on the issue's?rows, for example:Change
Update only the still-wrong phrase rows (and their direct compounds) that the issue marks as
?versus 國語辭典:惊叹/大表惊叹->驚嘆/大表驚嘆赞叹/赞叹不已/赞叹声/啧啧赞叹->讚嘆...咏叹->詠嘆叹服->嘆服叹为观止->嘆爲觀止(keeps OpenCC爲;s2tw/s2hkstill project to為)Left unchanged: literary rows where the issue already agrees on
歎(叹吁/叹羡/叹赏, etc.), and character-level叹 -> 嘆 歎.Also refresh
case_012(赞叹...->讚嘆...) and add#641testcases.Test plan
BYVoid_OpenCC_Issue_641_tan_to_tanandBYVoid_OpenCC_Issue_641_tan_controlsEvidence
Installed wheel
s2t(published dicts, before this fix):This branch, text-dict harness driving
data/dictionary/*.txt(config JSONs with ocd2 refs switched to text;STPhrases_GeneratedFromRegionalPhrasesstubbed):Harness summary:
The 16 baseline failures are the pre-existing stub gaps from omitting generated regional STPhrases (same class as other recent dictionary PRs).
sort.pyonSTPhrases.txtis idempotent after the edit.Please treat CI Bazel tests as authoritative; no local C++/Bazel toolchain was available here.
AI assistance
This fix was developed with AI assistance (Cursor / Grok) and verified locally as shown above.