Repository navigation
t2s: add 蔕 -> 蒂 conversion (#905) - #1452
Closed
stantheman0128 wants to merge 1 commit into
Closed
stantheman0128 wants to merge 1 commit into
stantheman0128 wants to merge 1 commit into
Conversation
Map the variant 蔕 to standard 蒂 in TSCharacters. Keep 谿 -> 溪 谿 (default 溪 first); phrase-level 谿 exceptions remain with BYVoid#901. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
|
罕見異體字不轉換。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #905.
Problem
TSCharacters.txthad no mapping for the variant蔕, so t2s left it unchanged:Issue #905 also discussed
谿. Current HEAD already has谿 -> 溪 谿(default溪first). Phrase-level keep-谿cases such as豁谿/谿刻/谿卡/谿壑are covered by #901 / PR #1447, not this change. Existing testcaseBYVoid_OpenCC_PR_464_xi_vs_xiexpects勃谿 -> 勃溪, so this PR does not add a勃谿identity phrase.Change
data/dictionary/TSCharacters.txt:Sorted with
data/scripts/sort.py. No change to the existing谿 -> 溪 谿entry.Test plan
BYVoid_OpenCC_Issue_905_*intest/testcases/testcases.json蘭谿/松谿still become兰溪/松溪(溪 first)Evidence
Repro before (packaged wheel dictionaries):
After this branch (config JSONs with
ocd2refs switched to text, drivingdata/dictionary/*.txton the branch):Harness summary (OpenCC 1.4.1 wheel, config
ocd2references rewritten to text):Please treat CI Bazel dictionary tests as authoritative.
AI assistance
This fix was developed with AI assistance (Cursor / Grok) and verified locally as shown above.