Repository navigation
Sign Windows release binaries on tag builds - #1482
Merged
Merged
Conversation
The five SignPath steps were gated on github.event_name == 'workflow_dispatch', so the run triggered by pushing a ver.* tag skipped signing entirely while still uploading the portable zip to the release. That is how the 1.4.1 Windows zip shipped unsigned, and README and NEWS now state that 1.4.2 onwards is Authenticode-signed. Detailed Changes: - **Signing condition**: gate the steps on `inputs.sign_windows_binaries || startsWith(github.ref, 'refs/tags/')` so a tag build always signs. A failed signing request now fails the job instead of silently producing an unsigned artifact. Manual dispatch on a non-tag ref is unchanged and still opt-in. - **Approval timeout**: set wait-for-completion-timeout-in-seconds to 1800. The release-signing policy requires a human approver, and the action's 600s default leaves little room to notice the request and approve it. - **Input description**: note that tag builds always sign.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The five SignPath steps in
release-winget.ymlwere gated ongithub.event_name == 'workflow_dispatch', so the run triggered by pushing aver.*tag skipped signing entirely — whileUpload to GitHub release(gated only onstartsWith(github.ref, 'refs/tags/')) still uploaded the portable zip to the release.That is how the 1.4.1 Windows zip shipped unsigned: run
29196952454shows all five signing steps asskipped. README and NEWS now state that Windows binaries are Authenticode-signed from 1.4.2 on, so the default path has to actually sign.Changes
inputs.sign_windows_binaries || startsWith(github.ref, 'refs/tags/'). A tag build always signs, and a failed signing request fails the job rather than silently producing an unsigned artifact. Manual dispatch on a non-tag ref is unchanged and still opt-in.wait-for-completion-timeout-in-seconds: 1800. Therelease-signingpolicy requires a human approver (confirmed in run32588647662, where approval took ~2m40s), and the action's default is 600s.Verification
release-signingwas exercised end to end in run32588647662(dry-run) and32589112455(publish); both Windows npm binaries came backsigned by CN=SignPath Foundation, ...; status: Valid. The winget artifact configuration (opencc-winget-portable-win32-x64) has not yet been signed underrelease-signing— the firstver.*tag after this merge will be its first run, and it will need a manual approval.