Repository navigation
Include Jieba plugin in source tarball and improve reproducibility - #1483
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Jieba 內容尚未納入封包冒煙測試，且相關文件仍描述舊 profile。
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
此 PR 將 Jieba 插件納入精簡原始碼封包，並產生可重現的 gzip、xz 封存檔。
Changes:
- 合併原始碼封包 profile。
- 正規化封存檔中繼資料與排序。
- 同時發佈
.tar.gz、.tar.xz。
File summaries
| File | Description |
|---|---|
CMakeLists.txt |
調整 profile 與排除規則。 |
.github/workflows/release-source.yml |
重封裝、測試並上傳兩種格式。 |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Merge the opencc-jieba profile into opencc so the release source tarball includes the Jieba segmentation plugin by default. Repack the CPack output for reproducible archives: normalize ownership to root:root, set timestamps to epoch 0, sort entries by name, and strip gzip metadata. Also produce .tar.xz alongside .tar.gz and exclude .gitattributes/.gitmodules from source packages. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge the opencc-jieba profile into opencc so the release source tarball includes the Jieba segmentation plugin by default. Repack the CPack output for reproducible archives: normalize ownership to root:root, set timestamps to epoch 0, sort entries by name, and strip gzip metadata. Also produce .tar.xz alongside .tar.gz and exclude .gitattributes/.gitmodules from source packages.