fix(providers): auto-inflate max_tokens for reasoning models - #379
Merged
Conversation
Reasoning models like glm-5-turbo consume max_tokens budget with thinking tokens, leaving no room for actual content. With max_tokens=4096 the model thinks for 127s and produces 0 chars of output. Auto-inflate to at least 16384 for known reasoning models, matching hermes's approach of max(user_config, reasoning_budget + output_budget). Closes #378 Bahtya
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_tokensto at least 16384 for known reasoning models (glm-5, deepseek-r, o1/o3/o4)max_tokensbudget with thinking tokens, leaving no room for actual content outputmax(user_config, reasoning_budget + output_budget)Test plan
max_tokens = 4096, send TG message to glm-5-turbo → should produce actual content instead of thinking-only outputCloses #378
Bahtya