feat(doctor): auto-complete missing config fields with --fix - #380
Merged
Conversation
Add `kestrel doctor --fix` that detects missing config fields and inserts them with Chinese comments explaining each field's purpose. Uses toml_edit to preserve existing formatting and values. Bahtya
- Remove agent.provider from auto-insert (empty string would match empty-named provider at runtime) - Replace dead check_and_fix() with lightweight check_missing() for read-only mode (avoids unnecessary TOML serialization) - Write .toml.bak backup before overwriting config with --fix Bahtya
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kestrel doctor --fixto detect and auto-complete missing config fieldstoml_editto incrementally insert missing fields with Chinese comments, preserving existing formatting and values[5/5] Config completenesscheck in doctorChanges
crates/kestrel-config/src/documented.rs— New module with all known scalar config fields, their default values and Chinese comments. Providesinsert_missing_fields()andapply_fix()functions.crates/kestrel-config/Cargo.toml— Addtoml_edit = "0.22"dependencysrc/commands/doctor.rs— Add 5th check for config completeness,--fixwrites back commented TOMLsrc/main.rs— Add--fixflag toDoctorsubcommandTest plan
cargo clippyclean, no warningscargo fmtcleankestrel doctorreports missing fields without modifying filekestrel doctor --fixadds missing fields with Chinese commentskestrel doctoragain shows "All known fields present"Bahtya