fix: sync images error

[yyzxw]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @yyzxw, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an error in the image synchronization process by updating the sync-images.sh script. The change specifically enables the helm template command to process development versions of charts, ensuring that all necessary image references are correctly identified and included in the synchronization, thereby preventing previous failures.

Highlights

• Helm Chart Processing: The helm template command in hack/sync-images.sh now includes the --devel flag. This ensures that development versions of Helm charts are considered when extracting image references, resolving potential issues with image synchronization.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• hack/sync-images.sh
  • Added the --devel flag to the helm template command to support development chart versions.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request adds the --devel flag to a helm template command, which appears to be a correct fix for an issue with syncing images from development chart versions. My review includes a suggestion to improve the robustness of the image parsing logic on the same line, making it less susceptible to formatting variations in the Helm output.

[gemini-code-assist]

The current pipeline for extracting image names is a bit fragile and can be improved for robustness.

• grep "image:" can unintentionally match lines in comments.
• awk '{print $2}' relies on a space existing between image: and the image name, and will fail if there isn't one (e.g., image:my-image).
• tr -d '"' only removes double quotes, but not single quotes which are also valid.

I suggest using a single, more powerful awk command to handle these cases correctly. This makes the script more robust against formatting variations in the helm template output.

Suggested change

	images=$(helm template --devel dataset/dataset | grep "image:" | awk '{print $2}' | tr -d '"')
	images=$(helm template --devel dataset/dataset | awk -F': *' '/^\s*image:/ {gsub("[\"']", "", $2); print $2}')