-
Notifications
You must be signed in to change notification settings - Fork 1
Change default model to HiDream-ai/HiDream-I1-Dev #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @tangming1996, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the default model used for the DiffusionPipeline to ensure proper functionality and compatibility with the DiT architecture. The previous default model was incompatible, leading to operational issues. The new default, "HiDream-ai/HiDream-I1-Dev", resolves this by providing a compatible and functional starting point for users. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the default model to HiDream-ai/HiDream-I1-Dev to ensure compatibility with the DiT architecture. While the change is appropriate, I've identified several related issues in utils/__init__.py that should be addressed for improved robustness and clarity, ideally in a follow-up pull request:
- Typo in argument name: The
--disbale-duplicate-schedulerargument is misspelled and should be--disable-duplicate-scheduler. - Inconsistent default value: The default for this argument is
False, but its help text states it should beTruefor HiDream models, which is now the default. This should be aligned to prevent unexpected behavior. - Incorrect boolean argument handling: Using
type=boolwithargparseis problematic. It's recommended to useaction='store_true'for boolean flags. - Typo in help text: The help text for the same argument contains a typo (
foshould befor).
8c36ff9 to
e1266b7
Compare
sd-legacy/stable-diffusion-v1-5 is not based on the DiT architecture and cannot run properly by default. Therefore, HiDream-ai/HiDream-I1-Dev is set as the default model.
sd-legacy/stable-diffusion-v1-5 is not based on the DiT architecture and cannot run properly by default. Therefore, HiDream-ai/HiDream-I1-Dev is set as the default model.