Skip to content

Conversation

@tangming1996
Copy link

sd-legacy/stable-diffusion-v1-5 is not based on the DiT architecture and cannot run properly by default. Therefore, HiDream-ai/HiDream-I1-Dev is set as the default model.

@gemini-code-assist
Copy link

Summary of Changes

Hello @tangming1996, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the default model used for the DiffusionPipeline to ensure proper functionality and compatibility with the DiT architecture. The previous default model was incompatible, leading to operational issues. The new default, "HiDream-ai/HiDream-I1-Dev", resolves this by providing a compatible and functional starting point for users.

Highlights

  • Default Model Update: The default model for the DiffusionPipeline has been updated from "sd-legacy/stable-diffusion-v1-5" to "HiDream-ai/HiDream-I1-Dev". This change addresses an incompatibility issue where the previous default model was not based on the DiT architecture and could not run properly.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the default model to HiDream-ai/HiDream-I1-Dev to ensure compatibility with the DiT architecture. While the change is appropriate, I've identified several related issues in utils/__init__.py that should be addressed for improved robustness and clarity, ideally in a follow-up pull request:

  • Typo in argument name: The --disbale-duplicate-scheduler argument is misspelled and should be --disable-duplicate-scheduler.
  • Inconsistent default value: The default for this argument is False, but its help text states it should be True for HiDream models, which is now the default. This should be aligned to prevent unexpected behavior.
  • Incorrect boolean argument handling: Using type=bool with argparse is problematic. It's recommended to use action='store_true' for boolean flags.
  • Typo in help text: The help text for the same argument contains a typo (fo should be for).

@tangming1996 tangming1996 force-pushed the patch-1 branch 2 times, most recently from 8c36ff9 to e1266b7 Compare February 2, 2026 06:15
sd-legacy/stable-diffusion-v1-5 is not based on the DiT architecture and cannot run properly by default. Therefore, HiDream-ai/HiDream-I1-Dev is set as the default model.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant