-
Notifications
You must be signed in to change notification settings - Fork 1
update minimax-test-01 resource requirements #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @yyzxw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the resource requirements for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Model Metadata Validation Results✅ All validations passed! Changed files:
Validation output:Please make sure all metadata files conform to the schema defined in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the resource requirements for the minimax-text-01 model, increasing the CPU from 8 to 16 and the GPU count from 8 to 14. While this increase seems appropriate for the model's size, there's a critical oversight. The memory field has not been updated in line with the new gpuCount, creating an inconsistency that could lead to deployment failures. I've left a comment on the relevant change with a recommendation for a fix.
| cpu: 16 | ||
| gpuCount: 14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an inconsistency in the resource requirements. The memory field on line 14 appears to be derived from gpuCount * perGPUMemoryGB. With the previous gpuCount of 8, memory was correctly set to 640 (8 * 80). Now that gpuCount is updated to 14, the memory field should be updated to 1120 (14 * 80) to reflect this change and ensure correct resource allocation.
part of #44