Skip to content

Conversation

@yyzxw
Copy link
Collaborator

@yyzxw yyzxw commented Oct 23, 2025

part of #44

https://docs.vllm.ai/en/latest/features/tool_calling.html#qwen-models
image

其次:vllm 中其实没有 --enable_reasoning 这个参数

@gemini-code-assist
Copy link

Summary of Changes

Hello @yyzxw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates tool calling capabilities for the qwq-32b model by modifying its metadata configuration. The update enables the model to automatically select and utilize external tools, leveraging the hermes parser for efficient processing of tool calls. This change aligns with broader efforts to enhance tool calling features for Qwen-based models, as referenced in the PR description.

Highlights

  • Tool Calling Enabled: The qwq-32b model has been updated to support automatic tool calling, enhancing its ability to interact with external functions.
  • Hermes Tool Call Parser: The hermes parser has been specifically configured as the tool call parser for the qwq-32b model, streamlining the processing of tool-related instructions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link

Model Metadata Validation Results

All validations passed!

Changed files:

  • models/alibaba/qwq-32b/metadata.yaml

Validation output:

✅ models/alibaba/qwq-32b/metadata.yaml - Valid


✅ models/alibaba/qwq-32b/metadata.yaml - Valid directory structure


✅ models/alibaba/qwq-32b/metadata.yaml - Valid Hugging Face source: Qwen/QwQ-32B
✅ models/alibaba/qwq-32b/metadata.yaml - Valid ModelScope source: Qwen/QwQ-32B



Please make sure all metadata files conform to the schema defined in docs/model.jsonschema.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the qwq-32b model specification to enable tool calling capabilities by adding the necessary vLLM runtime arguments. The change is functionally correct according to the vLLM documentation. I've provided one suggestion to improve the consistency of argument formatting within the YAML file, which will enhance maintainability.

- --tool-call-parser
- hermes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other arguments in this file that take a value (e.g., --reasoning_parser=deepseek_r1 on line 13), it's better to combine --tool-call-parser and its value hermes into a single argument using the = syntax. This improves readability and maintainability by keeping the argument format uniform.

    - --tool-call-parser=hermes

@github-actions
Copy link

Model Metadata Validation Results

All validations passed!

Changed files:

  • models/alibaba/qwen2.5-7b-instruct/metadata.yaml
  • models/alibaba/qwq-32b/metadata.yaml

Validation output:

✅ models/alibaba/qwen2.5-7b-instruct/metadata.yaml - Valid
✅ models/alibaba/qwq-32b/metadata.yaml - Valid


✅ models/alibaba/qwen2.5-7b-instruct/metadata.yaml - Valid directory structure
✅ models/alibaba/qwq-32b/metadata.yaml - Valid directory structure


✅ models/alibaba/qwen2.5-7b-instruct/metadata.yaml - Valid Hugging Face source: Qwen/Qwen2.5-VL-7B-Instruct
✅ models/alibaba/qwen2.5-7b-instruct/metadata.yaml - Valid ModelScope source: Qwen/Qwen2.5-VL-7B-Instruct
✅ models/alibaba/qwq-32b/metadata.yaml - Valid Hugging Face source: Qwen/QwQ-32B
✅ models/alibaba/qwq-32b/metadata.yaml - Valid ModelScope source: Qwen/QwQ-32B


⚠️ models/alibaba/qwen2.5-7b-instruct/metadata.yaml - Metadata name (qwen2.5-7b-instruct) doesn't match the normalized Hugging Face model ID (qwen2-5-vl-7b-instruct)
⚠️ models/alibaba/qwen2.5-7b-instruct/metadata.yaml - Display name (Qwen2.5-7B-Instruct) doesn't seem to match the Hugging Face model name (Qwen2.5-VL-7B-Instruct)

Please make sure all metadata files conform to the schema defined in docs/model.jsonschema.

@kebe7jun kebe7jun merged commit e3bde59 into main Oct 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants