Skip to content

Conversation

@yyzxw
Copy link
Collaborator

@yyzxw yyzxw commented Oct 23, 2025

@gemini-code-assist
Copy link

Summary of Changes

Hello @yyzxw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates and activates the reasoning output feature for the deepseek-r1 model. By modifying the model's deployment metadata, it ensures that the model is configured to utilize its reasoning parser, aligning with the broader initiative to support advanced reasoning outputs as referenced in the VLLM documentation.

Highlights

  • Reasoning Feature Enablement: The pull request enables reasoning capabilities for the deepseek-r1 model by adding specific runtime arguments to its deployment configuration.
  • Configuration Update: The metadata.yaml file for deepseek-r1 is updated to include --enable_reasoning and --reasoning_parser=deepseek_r1 in its customRuntimeArgs.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link

Model Metadata Validation Results

All validations passed!

Changed files:

  • models/deepseek/deepseek-r1/metadata.yaml

Validation output:

✅ models/deepseek/deepseek-r1/metadata.yaml - Valid


✅ models/deepseek/deepseek-r1/metadata.yaml - Valid directory structure


✅ models/deepseek/deepseek-r1/metadata.yaml - Valid Hugging Face source: deepseek-ai/DeepSeek-R1
✅ models/deepseek/deepseek-r1/metadata.yaml - Valid ModelScope source: deepseek-ai/DeepSeek-R1


⚠️ models/deepseek/deepseek-r1/metadata.yaml - Display name (🔥 DeepSeek-R1-0528) doesn't seem to match the Hugging Face model name (DeepSeek-R1)

Please make sure all metadata files conform to the schema defined in docs/model.jsonschema.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the configuration for the deepseek-r1 model to enable its reasoning capabilities. This is achieved by adding --enable_reasoning and --reasoning_parser=deepseek_r1 to the customRuntimeArgs for the model's deployment. The changes are syntactically correct and appear to be in line with the goal of enabling the vLLM reasoning feature as described in the pull request. The configuration change is consistent with the existing schema and type definitions. Overall, the change is straightforward and looks correct.

@yyzxw yyzxw force-pushed the update-deepseek-r1 branch from 1f573cb to 2bda0b2 Compare October 29, 2025 01:36
@github-actions
Copy link

Model Metadata Validation Results

All validations passed!

Changed files:

  • models/deepseek/deepseek-r1/metadata.yaml

Validation output:

✅ models/deepseek/deepseek-r1/metadata.yaml - Valid


✅ models/deepseek/deepseek-r1/metadata.yaml - Valid directory structure


✅ models/deepseek/deepseek-r1/metadata.yaml - Valid Hugging Face source: deepseek-ai/DeepSeek-R1
✅ models/deepseek/deepseek-r1/metadata.yaml - Valid ModelScope source: deepseek-ai/DeepSeek-R1


⚠️ models/deepseek/deepseek-r1/metadata.yaml - Display name (🔥 DeepSeek-R1-0528) doesn't seem to match the Hugging Face model name (DeepSeek-R1)

Please make sure all metadata files conform to the schema defined in docs/model.jsonschema.

@kebe7jun kebe7jun merged commit 8b89219 into main Oct 31, 2025
1 check passed
@kebe7jun kebe7jun deleted the update-deepseek-r1 branch October 31, 2025 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants