-
Notifications
You must be signed in to change notification settings - Fork 1
update deepseek-r1 #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @yyzxw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates and activates the reasoning output feature for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Model Metadata Validation Results✅ All validations passed! Changed files:
Validation output:Please make sure all metadata files conform to the schema defined in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the configuration for the deepseek-r1 model to enable its reasoning capabilities. This is achieved by adding --enable_reasoning and --reasoning_parser=deepseek_r1 to the customRuntimeArgs for the model's deployment. The changes are syntactically correct and appear to be in line with the goal of enabling the vLLM reasoning feature as described in the pull request. The configuration change is consistent with the existing schema and type definitions. Overall, the change is straightforward and looks correct.
1f573cb to
2bda0b2
Compare
Model Metadata Validation Results✅ All validations passed! Changed files:
Validation output:Please make sure all metadata files conform to the schema defined in |
part of #44

https://docs.vllm.ai/en/latest/features/reasoning_outputs.html