Skip to content

Conversation

@yyzxw
Copy link
Collaborator

@yyzxw yyzxw commented Oct 27, 2025

part of #44

vllm 没有 --enable-reasoning 这个参数

@gemini-code-assist
Copy link

Summary of Changes

Hello @yyzxw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a configuration issue within the deepseek-r1-distill-qwen-14b model's metadata.yaml file. It specifically removes an invalid vllm runtime argument and rectifies a parameter naming convention, ensuring the model can be correctly deployed and executed within the vllm environment without encountering unsupported argument errors. This change is part of a larger effort to refine model configurations.

Highlights

  • Configuration Correction: Removed the unsupported --enable_reasoning custom runtime argument from the metadata.yaml file, as it is not recognized by vllm.
  • Parameter Renaming: Corrected the reasoning_parser argument name from using an underscore (--reasoning_parser) to a hyphen (--reasoning-parser) to align with vllm's expected parameter format.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link

Model Metadata Validation Results

All validations passed!

Changed files:

  • models/deepseek/deepseek-r1-distill-qwen-14b/metadata.yaml

Validation output:

✅ models/deepseek/deepseek-r1-distill-qwen-14b/metadata.yaml - Valid


✅ models/deepseek/deepseek-r1-distill-qwen-14b/metadata.yaml - Valid directory structure


✅ models/deepseek/deepseek-r1-distill-qwen-14b/metadata.yaml - Valid Hugging Face source: deepseek-ai/DeepSeek-R1-Distill-Qwen-14B
✅ models/deepseek/deepseek-r1-distill-qwen-14b/metadata.yaml - Valid ModelScope source: deepseek-ai/DeepSeek-R1-Distill-Qwen-14B



Please make sure all metadata files conform to the schema defined in docs/model.jsonschema.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次变更修正了 deepseek-r1-distill-qwen-14b 模型的 vLLM 启动参数,移除了不再支持的 --enable_reasoning 参数,并将 --reasoning_parser 修正为 --reasoning-parser,这是一个正确的修复。不过,我注意到 models/deepseek/deepseek-r1-distill-qwen-32b/metadata.yaml 文件中似乎也存在同样的问题(使用了 --enable_reasoning--reasoning_parser)。为了确保所有相关模型都能成功部署并保持配置的一致性,建议在此次提交中一并修复 32b 模型的配置。

@github-actions
Copy link

Model Metadata Validation Results

All validations passed!

Changed files:

  • models/deepseek/deepseek-r1-distill-qwen-14b/metadata.yaml
  • models/deepseek/deepseek-r1-distill-qwen-32b/metadata.yaml

Validation output:

✅ models/deepseek/deepseek-r1-distill-qwen-14b/metadata.yaml - Valid
✅ models/deepseek/deepseek-r1-distill-qwen-32b/metadata.yaml - Valid


✅ models/deepseek/deepseek-r1-distill-qwen-14b/metadata.yaml - Valid directory structure
✅ models/deepseek/deepseek-r1-distill-qwen-32b/metadata.yaml - Valid directory structure


✅ models/deepseek/deepseek-r1-distill-qwen-14b/metadata.yaml - Valid Hugging Face source: deepseek-ai/DeepSeek-R1-Distill-Qwen-14B
✅ models/deepseek/deepseek-r1-distill-qwen-14b/metadata.yaml - Valid ModelScope source: deepseek-ai/DeepSeek-R1-Distill-Qwen-14B
✅ models/deepseek/deepseek-r1-distill-qwen-32b/metadata.yaml - Valid Hugging Face source: deepseek-ai/DeepSeek-R1-Distill-Qwen-32B
✅ models/deepseek/deepseek-r1-distill-qwen-32b/metadata.yaml - Valid ModelScope source: deepseek-ai/DeepSeek-R1-Distill-Qwen-32B



Please make sure all metadata files conform to the schema defined in docs/model.jsonschema.

@yyzxw yyzxw force-pushed the fix-ds-r1-distill-qwen-14b branch from 6dcade3 to 44e2ae8 Compare October 27, 2025 06:36
@github-actions
Copy link

Model Metadata Validation Results

All validations passed!

Changed files:

  • models/deepseek/deepseek-r1-distill-qwen-14b/metadata.yaml

Validation output:

✅ models/deepseek/deepseek-r1-distill-qwen-14b/metadata.yaml - Valid


✅ models/deepseek/deepseek-r1-distill-qwen-14b/metadata.yaml - Valid directory structure


✅ models/deepseek/deepseek-r1-distill-qwen-14b/metadata.yaml - Valid Hugging Face source: deepseek-ai/DeepSeek-R1-Distill-Qwen-14B
✅ models/deepseek/deepseek-r1-distill-qwen-14b/metadata.yaml - Valid ModelScope source: deepseek-ai/DeepSeek-R1-Distill-Qwen-14B



Please make sure all metadata files conform to the schema defined in docs/model.jsonschema.

@kebe7jun kebe7jun merged commit f08413e into main Oct 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants