-
Notifications
You must be signed in to change notification settings - Fork 1
fix: update ds-r1-distill-qwen-14b #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @yyzxw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a configuration issue within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Model Metadata Validation Results✅ All validations passed! Changed files:
Validation output:Please make sure all metadata files conform to the schema defined in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
本次变更修正了 deepseek-r1-distill-qwen-14b 模型的 vLLM 启动参数,移除了不再支持的 --enable_reasoning 参数,并将 --reasoning_parser 修正为 --reasoning-parser,这是一个正确的修复。不过,我注意到 models/deepseek/deepseek-r1-distill-qwen-32b/metadata.yaml 文件中似乎也存在同样的问题(使用了 --enable_reasoning 和 --reasoning_parser)。为了确保所有相关模型都能成功部署并保持配置的一致性,建议在此次提交中一并修复 32b 模型的配置。
Model Metadata Validation Results✅ All validations passed! Changed files:
Validation output:Please make sure all metadata files conform to the schema defined in |
6dcade3 to
44e2ae8
Compare
Model Metadata Validation Results✅ All validations passed! Changed files:
Validation output:Please make sure all metadata files conform to the schema defined in |
part of #44
vllm 没有
--enable-reasoning这个参数