Skip to content

Conversation

@yyzxw
Copy link
Collaborator

@yyzxw yyzxw commented Oct 27, 2025

part of #44

@gemini-code-assist
Copy link

Summary of Changes

Hello @yyzxw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the runtime configuration for the deepseek-r1-distill-qwen-32b model. The changes involve correcting a command-line argument's syntax and removing a flag, ensuring the model's execution parameters are accurate and up-to-date. This is part of a larger effort to maintain consistency and correctness across model configurations.

Highlights

  • Configuration Update: The metadata.yaml file for the deepseek-r1-distill-qwen-32b model has been updated to refine its custom runtime arguments.
  • Argument Renaming: The --reasoning_parser argument has been corrected to --reasoning-parser, standardizing the argument format.
  • Argument Removal: The --enable_reasoning custom runtime argument has been removed from the model's configuration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link

Model Metadata Validation Results

All validations passed!

Changed files:

  • models/deepseek/deepseek-r1-distill-qwen-32b/metadata.yaml

Validation output:

✅ models/deepseek/deepseek-r1-distill-qwen-32b/metadata.yaml - Valid


✅ models/deepseek/deepseek-r1-distill-qwen-32b/metadata.yaml - Valid directory structure


✅ models/deepseek/deepseek-r1-distill-qwen-32b/metadata.yaml - Valid Hugging Face source: deepseek-ai/DeepSeek-R1-Distill-Qwen-32B
✅ models/deepseek/deepseek-r1-distill-qwen-32b/metadata.yaml - Valid ModelScope source: deepseek-ai/DeepSeek-R1-Distill-Qwen-32B



Please make sure all metadata files conform to the schema defined in docs/model.jsonschema.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the configuration for the deepseek-r1-distill-qwen-32b model. The changes involve removing the --enable_reasoning flag and correcting the --reasoning_parser flag to use kebab-case (--reasoning-parser), which aligns it with the other command-line arguments in the file. While this is a good improvement for consistency, I've added a comment to suggest applying a similar convention to the flag's value.

- --enforce-eager
- --enable_reasoning
- --reasoning_parser=deepseek_r1
- --reasoning-parser=deepseek_r1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with the model name (deepseek-r1-distill-qwen-32b) and the convention of using kebab-case for identifiers, consider changing the parser name to deepseek-r1. You've correctly updated the argument from --reasoning_parser to --reasoning-parser, and it would be more consistent if the value followed the same pattern.

    - --reasoning-parser=deepseek-r1

@kebe7jun kebe7jun merged commit aee3036 into main Oct 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants