[codex] Fix Vortice video processor color range - #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IMIRROR_D3D_COLOR_SPACE=defaultas a quick runtime escape hatch for the previous driver-default behavior, plusbt709-studiofor comparison.Why
On v0.7.2, the GPU path could render whites/highlights brighter than the Mac source while blacks stayed close. The FFmpeg software fallback looked correct on the same sender/display, which pointed to the GPU NV12 -> BGRA video processor conversion rather than the sender or monitor profile.
Validation
dotnet build .\iMirror.sln -c Release --no-restorepassed with 0 warnings / 0 errors.dotnet test .\MacMirrorReceiver.Tests\MacMirrorReceiver.Tests.csproj -c Release --no-restorepassed: 63 tests.gpuBinding=Vortice,ffmpegPipeline=0, andD3D11 video processor color space: mode=bt709-full.