Migrate from JUnit 4 to JUnit 5#1
Draft
BalusC wants to merge 2 commits into
Draft
Conversation
Swap junit:junit + arquillian-junit-container for org.junit.jupiter + arquillian-junit5-container. Update ~100 IT classes: imports, @RunWith → @ExtendWith(ArquillianExtension.class), @Before/@after → @BeforeEach/ @AfterEach, assertion arg order (message moves to last). ArquillianBase's @rule TestWatcher becomes a nested FailedResponseLogger implementing JUnit 5's TestWatcher, registered via @ExtendWith on the base class (inherited by subclasses). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Ported from Jakarta Faces TCK util module. Prints RUNNING/SKIPPED/FAILED events tagged with the GlassFish pool slot and a per-JVM N/total counter, with failure throwables inlined for log-only diagnosis. Auto-registered via META-INF/services so every IT picks it up. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swap junit:junit + arquillian-junit-container for org.junit.jupiter + arquillian-junit5-container. Update ~100 IT classes: imports,
@RunWith→@ExtendWith(ArquillianExtension.class),@Before/@After→@BeforeEach/@AfterEach, assertion arg order (message moves to last).ArquillianBase's@Rule TestWatcherbecomes a nestedFailedResponseLoggerimplementing JUnit 5'sTestWatcher, registered via@ExtendWithon the base class (inherited by subclasses).Also adds a
ProgressListener(ported from the Faces TCK) auto-registered viaMETA-INF/services, printing one tagged line per test event ([RUNNING][SLOT1][module][N/M] ClassIT#test).NOTE: this is a Draft PR because the target branch (jakartaee#368) is not yet merged. This is a sequential PR because the work partly depends on the work done in the target branch (so merge conflicts are avoided).