Log fix#109
Conversation
lvnacy
left a comment
lvnacy
left a comment
There was a problem hiding this comment.
Left a few comments with regard to the data captured in the various meta objects. Open to discussing potential solutions for these.
There was a problem hiding this comment.
Regarding the rateLimit, can we include the rateLimitData.timeout, rateLimitData.limit, rateLimitData.method, rateLimitData.path, rateLimitData.route, and rateLimitData.global details in the error object that gets returned?
There was a problem hiding this comment.
Alright. I will look at how we can implement pino's mixin() function for this.
There was a problem hiding this comment.
Same as in RateLimit.ts, can we create an object to include the discordId, duration, isActive, and description details in the error object that is returned? Perhaps we extend the Error object to capture this data and serve it when called, as a custom error log option, ie Log.timecardData.
There was a problem hiding this comment.
Yes we can definitely do this, will start working on this.
| logCommandStart(ctx: CommandContext): void { | ||
| Log.info(`/${ctx.commandName} ran ${ctx.user.username}#${ctx.user.discriminator}`, { | ||
| indexMeta: true, | ||
| meta: { |
There was a problem hiding this comment.
Same as above for RateLimit.ts and Checkout.ts. Since we're in the process of updating some of the log captures, might as well solve this now.
LordRanchoatos
left a comment
LordRanchoatos
left a comment
There was a problem hiding this comment.
This gets us going with the logger, we will still need to capture the meta data left out while implementing this.
3 participants
Took out the logDNA.