Set module's assetpath attribute to fix component's importPath()#88
Open
mjcctech wants to merge 2 commits intoBanno:masterfrom
Open
Set module's assetpath attribute to fix component's importPath()#88mjcctech wants to merge 2 commits intoBanno:masterfrom
mjcctech wants to merge 2 commits intoBanno:masterfrom
Conversation
added 2 commits
April 18, 2018 12:59
It is possible to specify directory where components are installed. Default value is './src'
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
==========================================
+ Coverage 97.02% 97.04% +0.02%
==========================================
Files 2 2
Lines 269 271 +2
Branches 65 67 +2
==========================================
+ Hits 261 263 +2
Misses 8 8
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
==========================================
+ Coverage 97.02% 97.04% +0.02%
==========================================
Files 2 2
Lines 269 271 +2
Branches 65 67 +2
==========================================
+ Hits 261 263 +2
Misses 8 8
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When component is loaded by polymer-webpack-loader it lose information about original path. Polymer provide importPatch property(https://www.polymer-project.org/2.0/docs/devguide/dom-template#urls-in-templates). But to work it correctly with webpack loader assetpath attribute should be set on module.