Another update for cut atom#1723
Open
tristan-huber wants to merge 4 commits into
Open
Conversation
Collaborator
Author
|
TODO:
|
Use "measureVolume" to determine if a cut operation resulted in a no-op or in an empty result. Introduces a sentinel empty geometry key adds explicit no-ops for whenever the empty geom shows up mocks empty geometries as replicad compound-of-nothing objects for code atom add explicit check to the mesher for empty objects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates logic around cut operations in abundance.
Specifically it turns out that Volume computation for 3d solids is fast. Fast enough that we can use it to double check the class of interaction which a cut operation falls into. The cases being:
Only the third case requires a new entry in the cache.
Prior to this PR case 1 was fairly common and would lead us to re-instantiate identical objects. This was particularly pervasive in assemblies. In an initial effort to fix this I conflated cases 1 and 2 which would sometimes allow shapes to persist after when they should have been cut away to nothing.