17 chore ci update version badge being skipped on merge - #24
Conversation
Grants 'pull-requests: write' permission and switches to using RELEASE_PLEASE_TOKEN in the CICD workflow. Removes 'pull-request' field from release-please-config.json for streamlined configuration.
Changed the trigger condition for the update-version-badge job to run only on pushes to the main branch, instead of relying on the release-please job output.
|
🚅 Deployed to the BarryHenry-Portfolio-Web-pr-24 environment in upbeat-freedom
|
Summary of ChangesHello @BarryHenryJr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on refining the project's release automation by improving security and streamlining the overall release process. It involves updating GitHub Actions permissions and token usage, alongside a configuration change in Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the release automation workflow by modifying the release-please-config.json file. The change removes the "pull-request": false configuration, which will now allow release-please to create pull requests for new releases, aligning with the tool's default behavior in a GitHub Actions environment. This change is correct and directly supports the goal of streamlining the release process. Based on the pull request description, this is part of a larger update to the CI/CD pipeline, and it appears to be a sound approach to manage releases more effectively.
There was a problem hiding this comment.
Pull request overview
This pull request updates the release automation workflow to enable pull request creation by release-please and modifies token authentication. However, a critical bug is introduced in the workflow logic.
Key Changes
- Removed
"pull-request": falsefrom release-please configuration to allow PR creation - Updated token from
GITHUB_TOKENtoRELEASE_PLEASE_TOKENfor release-please and version badge update - Added
pull-requests: writepermission to the release-please job - Removed the dependency on release-please from the update-version-badge job
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| release-please-config.json | Removes the setting that disabled PR creation, allowing release-please to create pull requests |
| .github/workflows/cicd.yml | Updates permissions and tokens, but introduces a critical bug by changing when the version badge update runs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Added logic to check if the version badge in README.md matches the current package version before updating. This prevents unnecessary updates when the badge is already up to date.
This pull request updates the release automation workflow and its configuration to improve security and streamline the release process. The main changes involve updating permissions and tokens in the GitHub Actions workflow and adjusting the release-please configuration.
Workflow and automation updates:
cicd.ymlworkflow to grantpull-requests: writepermissions, which allows the workflow to create or update pull requests as part of the release process.GITHUB_TOKENtoRELEASE_PLEASE_TOKENfor improved security and separation of concerns.Configuration changes:
"pull-request": falsesetting fromrelease-please-config.json, allowing release-please to create pull requests as part of the release process.