Skip to content

17 chore ci update version badge being skipped on merge - #24

Merged
BarryHenryJr merged 3 commits into
mainfrom
17-chore-ci-update-version-badge-being-skipped-on-merge
Jan 9, 2026
Merged

BarryHenryJr merged 3 commits into
mainfrom
17-chore-ci-update-version-badge-being-skipped-on-merge

Conversation

@BarryHenryJr

Copy link
Copy Markdown
Owner

This pull request updates the release automation workflow and its configuration to improve security and streamline the release process. The main changes involve updating permissions and tokens in the GitHub Actions workflow and adjusting the release-please configuration.

Workflow and automation updates:

  • Updated the cicd.yml workflow to grant pull-requests: write permissions, which allows the workflow to create or update pull requests as part of the release process.
  • Changed the authentication token used by the release and version badge update steps from GITHUB_TOKEN to RELEASE_PLEASE_TOKEN for improved security and separation of concerns.

Configuration changes:

  • Removed the "pull-request": false setting from release-please-config.json, allowing release-please to create pull requests as part of the release process.

Grants 'pull-requests: write' permission and switches to using RELEASE_PLEASE_TOKEN in the CICD workflow. Removes 'pull-request' field from release-please-config.json for streamlined configuration.
Changed the trigger condition for the update-version-badge job to run only on pushes to the main branch, instead of relying on the release-please job output.
@BarryHenryJr BarryHenryJr self-assigned this Jan 9, 2026
Copilot AI review requested due to automatic review settings January 9, 2026 18:13
@BarryHenryJr BarryHenryJr added the bug Something isn't working label Jan 9, 2026
@BarryHenryJr BarryHenryJr linked an issue Jan 9, 2026 that may be closed by this pull request
@railway-app

railway-app Bot commented Jan 9, 2026

Copy link
Copy Markdown

🚅 Deployed to the BarryHenry-Portfolio-Web-pr-24 environment in upbeat-freedom

Service Status Web Updated (UTC)
BarryHenry-Portfolio-Web ✅ Success (View Logs) Jan 9, 2026 at 6:41 pm

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @BarryHenryJr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the project's release automation by improving security and streamlining the overall release process. It involves updating GitHub Actions permissions and token usage, alongside a configuration change in release-please to facilitate automated pull request creation, leading to a more robust and efficient release pipeline.

Highlights

  • Workflow Permissions Update: The cicd.yml workflow has been updated to grant pull-requests: write permissions, which is essential for the workflow to create or update pull requests during the release process.
  • Authentication Token Change: The authentication token used by the release and version badge update steps has been switched from GITHUB_TOKEN to RELEASE_PLEASE_TOKEN to enhance security and ensure better separation of concerns.
  • Release-Please Configuration Adjustment: The release-please-config.json file has been modified to remove the "pull-request": false setting, thereby enabling release-please to create pull requests as part of the automated release workflow.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/cicd.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@railway-app
railway-app Bot temporarily deployed to upbeat-freedom / BarryHenry-Portfolio-Web-pr-24 January 9, 2026 18:13 Destroyed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the release automation workflow by modifying the release-please-config.json file. The change removes the "pull-request": false configuration, which will now allow release-please to create pull requests for new releases, aligning with the tool's default behavior in a GitHub Actions environment. This change is correct and directly supports the goal of streamlining the release process. Based on the pull request description, this is part of a larger update to the CI/CD pipeline, and it appears to be a sound approach to manage releases more effectively.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the release automation workflow to enable pull request creation by release-please and modifies token authentication. However, a critical bug is introduced in the workflow logic.

Key Changes

  • Removed "pull-request": false from release-please configuration to allow PR creation
  • Updated token from GITHUB_TOKEN to RELEASE_PLEASE_TOKEN for release-please and version badge update
  • Added pull-requests: write permission to the release-please job
  • Removed the dependency on release-please from the update-version-badge job

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
release-please-config.json Removes the setting that disabled PR creation, allowing release-please to create pull requests
.github/workflows/cicd.yml Updates permissions and tokens, but introduces a critical bug by changing when the version badge update runs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/cicd.yml
Added logic to check if the version badge in README.md matches the current package version before updating. This prevents unnecessary updates when the badge is already up to date.
@railway-app
railway-app Bot temporarily deployed to upbeat-freedom / BarryHenry-Portfolio-Web-pr-24 January 9, 2026 18:40 Destroyed
@BarryHenryJr
BarryHenryJr merged commit da9f533 into main Jan 9, 2026
7 checks passed
@railway-app
railway-app Bot temporarily deployed to barryhenry-portfolio-web / BarryHenry-Portfolio-Web-pr-24 January 9, 2026 18:44 Destroyed
@BarryHenryJr
BarryHenryJr deleted the 17-chore-ci-update-version-badge-being-skipped-on-merge branch January 9, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore (ci): update-version-badge being skipped on merge

2 participants