create deeplink for upgrade to unlimited #4153
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a deep link for the 'upgrade to unlimited' page. The changes include a new intent filter in AndroidManifest.xml and logic in app_shell.dart to handle the link. The implementation is straightforward, and the suggested improvement to make the deep link handling more robust by adding a host check to the URI parsing logic has been retained as it ensures only intended URLs trigger navigation to the upgrade page.
app/lib/core/app_shell.dart
Outdated
| ), | ||
| ); | ||
| } | ||
| } else if (uri.pathSegments.first == 'upgrade') { |
There was a problem hiding this comment.
The condition uri.pathSegments.first == 'upgrade' is not specific enough as it doesn't check the URI's host. The AndroidManifest.xml specifies this deep link for the h.omi.me host. To make the handling more robust and prevent accidentally matching URLs from other hosts (e.g., https://another.site/upgrade), the host should be explicitly checked. Using uri.path == '/upgrade' is also more direct for an exact path match.
| } else if (uri.pathSegments.first == 'upgrade') { | |
| } else if (uri.host == 'h.omi.me' && uri.path == '/upgrade') { |
added deep link for unlimited plan subscription page
ScreenRecording_01-19-2026.12-07-19_1.mov