fix dialog navigator context crash #4309
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a critical crash caused by using an outdated BuildContext when dismissing a dialog. The change in app/lib/pages/apps/list_item.dart properly uses the context from the showDialog builder, which resolves the issue.
This is a common anti-pattern in Flutter, and I've identified other areas in the codebase with the same vulnerability. To improve application stability, I strongly recommend applying the same fix in these locations:
app/lib/pages/apps/app_detail/app_detail.dart(lines 931, 934)app/lib/pages/apps/app_detail/app_detail.dart(lines 1180-1183)app/lib/pages/apps/app_detail/app_detail.dart(lines 1782-1784)
A project-wide audit for similar showDialog implementations would be beneficial to prevent future crashes.
mdmohsin7
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
omi/app/lib/pages/apps/list_item.dart
Line 189 in 40754f7
here Navigator.pop used outdated context, so no navigator existed above it
closes #4308