Skip to content

fix(simulate,predict): stabilized conditionals, newdata validation, response scale - #204

Merged
MaartenMarsman merged 1 commit into
developfrom
audit/32-simulate-predict
Oct 19, 2026
Merged

MaartenMarsman merged 1 commit into
developfrom
audit/32-simulate-predict

Conversation

@MaartenMarsman

Copy link
Copy Markdown
Collaborator

Brief 32 of the August 2026 audit. Report: dev/review-2026-08/reports/32-simulate-predict-batch.md

Constituent changes:

  • fix(simulate): stabilize the MRF full conditional and honour interrupts
  • fix(predict): build the posterior-mean precision diagonal from the draws
  • fix(centrality): read the edge order off the fit instead of assuming it
  • fix(predict): mask undefined rows and report responses on the original scale
  • fix(predict): validate newdata columns, simulate sizes, and the cores default
  • test(predict): cover the conditioning mask, the category scale, and the edge order
  • test(predict): compare relabel-invariant predictions by value, not by label
  • docs(predict): state the category scale, newdata rules, and NA behaviour
  • test(simulate): cover the stabilized full conditional
  • chore(style): drop a stray blank line in simulate_mrf.R

Part of the 12-PR stack replacing #200 (one PR per audit brief). Squash-merge in stack order starting from PR 29, then run dev/review-2026-08/restack.sh to rebase the remaining PRs. The combined tip of the stack is bit-identical to the tree that passed the stage gates: full suite 0 fail / 9276 pass, R CMD check --as-cran 0 errors, 0 warnings, 3 benign NOTEs.

Base automatically changed from audit/31-suite-hygiene to develop August 13, 2026 21:44
…esponse scale

Brief 32 of the August 2026 audit. Report: dev/review-2026-08/reports/32-simulate-predict-batch.md

Constituent changes:
- fix(simulate): stabilize the MRF full conditional and honour interrupts
- fix(predict): build the posterior-mean precision diagonal from the draws
- fix(centrality): read the edge order off the fit instead of assuming it
- fix(predict): mask undefined rows and report responses on the original scale
- fix(predict): validate newdata columns, simulate sizes, and the cores default
- test(predict): cover the conditioning mask, the category scale, and the edge order
- test(predict): compare relabel-invariant predictions by value, not by label
- docs(predict): state the category scale, newdata rules, and NA behaviour
- test(simulate): cover the stabilized full conditional
- chore(style): drop a stray blank line in simulate_mrf.R
@MaartenMarsman
MaartenMarsman force-pushed the audit/32-simulate-predict branch from afb7594 to 5dfa57c Compare October 16, 2026 17:12
@codecov

codecov Bot commented Oct 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.22222% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.79%. Comparing base (0807fba) to head (5dfa57c).

Files with missing lines Patch % Lines
src/mrf_simulation.cpp 85.71% 3 Missing ⚠️
R/simulate_predict.R 98.18% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #204      +/-   ##
===========================================
- Coverage    92.84%   92.79%   -0.06%     
===========================================
  Files          115      115              
  Lines        18697    18828     +131     
===========================================
+ Hits         17360    17471     +111     
- Misses        1337     1357      +20     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MaartenMarsman
MaartenMarsman merged commit 535497d into develop Oct 19, 2026
8 of 10 checks passed
@MaartenMarsman
MaartenMarsman deleted the audit/32-simulate-predict branch October 19, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant