Repository navigation
fix(prior-sampler): acceptance targets, honest family reporting, dead knobs - #205
Merged
Merged
Conversation
MaartenMarsman
force-pushed
the
audit/32-simulate-predict
branch
from
October 16, 2026 17:12
afb7594 to
5dfa57c
Compare
MaartenMarsman
force-pushed
the
audit/33-sampler-knobs
branch
from
October 16, 2026 17:12
470cba6 to
67b9c24
Compare
MaartenMarsman
force-pushed
the
audit/33-sampler-knobs
branch
3 times, most recently
from
October 19, 2026 14:36
4b4b1eb to
22502c5
Compare
… knobs Brief 33 of the August 2026 audit. Report: dev/review-2026-08/reports/33-sampler-knobs.md Constituent changes: - fix(prior-sampler): deprecate the unused step_size argument of sample_ggm_prior() - fix(prior-sampler): forward bgm()'s acceptance target to the joint prior chain - fix(prior-sampler): report the graph-prior family sample_graph_prior() ran - chore(dead-code): drop the unused gradient parameters in the HMC utilities
MaartenMarsman
force-pushed
the
audit/33-sampler-knobs
branch
from
October 19, 2026 14:37
22502c5 to
f6e670a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #205 +/- ##
===========================================
+ Coverage 92.79% 92.84% +0.04%
===========================================
Files 115 115
Lines 18827 18822 -5
===========================================
+ Hits 17471 17475 +4
+ Misses 1356 1347 -9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief 33 of the August 2026 audit. Report: dev/review-2026-08/reports/33-sampler-knobs.md
Constituent changes:
Part of the 12-PR stack replacing #200 (one PR per audit brief). Squash-merge in stack order starting from PR 29, then run dev/review-2026-08/restack.sh to rebase the remaining PRs. The combined tip of the stack is bit-identical to the tree that passed the stage gates: full suite 0 fail / 9276 pass, R CMD check --as-cran 0 errors, 0 warnings, 3 benign NOTEs.