Repository navigation
fix(sensitivity): make the run-to-run noise window symmetric in the two refits - #216
Merged
Merged
Conversation
…wo refits wobble_yardstick() selected threshold-relevant edges on the first refit alone, so an edge that saturated in the replicate but not in the first refit could carry the noise band up, and the reverse case was dropped silently (handoff F5). The band now pools the edges inside the window in both refits and counts an edge inside it in only one of them as censored, whichever refit that is. Roxygen, the printed censored line, the vignette and NEWS state the rule; two tests cover the swapped-input symmetry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handoff finding F5 (dev/audit/2026-10-16-prior-sensitivity-review-handoff.md).
wobble_yardstick()selected threshold-relevant edges (|log BF| <= 3 log 10) on the first refit alone. An edge that saturated in the replicate but not in the first refit could carry the noise band up, and the reverse case was dropped without being counted. The band now pools the edges inside the window in both refits, and an edge inside it in only one of them, saturated or finite beyond the window, is counted as censored whichever refit that is. The tutorial's Appendix D already describes this rule.Changes: R/prior_sensitivity.R (the function, its roxygen, the printed censored line), the regenerated Rd, one sentence in vignettes/prior-sensitivity.Rmd, two tests for the swapped-input symmetry, and a NEWS entry saying the band and the within-noise classification can change for edges near the thresholds.
Reproduction (dev/review-2026-08/repro/run-f5.sh, develop vs this branch):
test-prior-sensitivity.R on the branch: 104 pass, 0 fail (every-run tier).