Repository navigation
fix(sensitivity): drop the vary argument, refuse raw-rate diagonal priors - #218
Merged
Merged
Conversation
…iors prior_sensitivity_check() holds the standardized diagonal rate eta fixed and moves the raw rate with the slab scale. A fit whose diagonal prior was given as a raw rate stops with an error; the man page shows the refit loop for that case. DESCRIPTION Date updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prior_sensitivity_check()loses thevaryargument. The sweep holds the standardized diagonal rateetafixed and moves the raw rate with the slab scale. A GGM or mixed fit whose diagonal prior was given as a rawratestops with an error; the man page gains a section with the refit loop for that case.Background: with the raw rate held fixed, the graph-dependent normalizing constant of the hierarchical prior changes with the scale and the importance weights did not carry it; the refits also ran with Z-ratio constants for the original rate. With
etaheld fixed the standardization separates the scale from that constant, which cancels in the importance ratios; a GGM and a mixed hierarchical fit reweighted to 2x reproduce direct refits to within 0.01 in inclusion probability (dev/audit/checks/2026-10-22-hierarchical-reweight-check.txt).Verification