added timeout to send the information and not get long waiting time#18
added timeout to send the information and not get long waiting time#18andrescevp wants to merge 1 commit intoBedrockStreaming:masterfrom
Conversation
|
Why not, but as it is strongly recommended to use StatsD through UDP protocol, i'll ask myself about this PR usage. Do we really want this ? ping @omansour |
|
I think that yes, because if the server don't answer we have a issue about the connection, my point is avoid useless waiting time, if the server is down we just discart the information (bad luck, call you sys admin =P) |
|
txs for contributing ! ok, but this value should be a parameter somehow. maybe not used a constant but a property with a default value, and add a setter ? |
|
@andrescevp using UDP, you not wait for server response (fire and forget), and you dont have waiting time. That's why i ask myself about the consequences of this parameter. |
|
we cant just considering this like a regular timeout for those not using udp. But not in a constant :) |
No description provided.