test & refactor: split show() into focused functions and add tests for SearchByNameUI#69
Open
test & refactor: split show() into focused functions and add tests for SearchByNameUI#69
Conversation
Contributor
skaik-mo
commented
Apr 24, 2025
skaik-mo
commented
- Break down show() into smaller functions (displayRecipe, handleError, etc.)
- Add comprehensive UI tests for all scenarios
- Improve testability and maintainability
- Keep same external behavior
…r SearchByNameUI - Break down show() into smaller functions (displayRecipe, handleError, etc.) - Add comprehensive UI tests for all scenarios - Improve testability and maintainability - Keep same external behavior
skaik-mo
requested review from
BassantM,
Eng-Light,
Mostafa-khaled21,
MurtadhaAhmedJ,
YaseenOmar,
hazemka,
iZyadNasser,
ismailElkalili,
sohahamdy2,
tasneem-hakeem and
yousef-osama11
BassantM
approved these changes
Apr 26, 2025
Contributor
BassantM
left a comment
BassantM
left a comment
There was a problem hiding this comment.
After trying to solve conflict we have another one, in line 33 in "SearchByNameUI" class.
…e_ui # Conflicts: # src/main/kotlin/model/Recipe.kt # src/main/kotlin/ui/features_ui/SearchByNameUI.kt # src/main/kotlin/utils/Strings.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.