Fix test helper validation to match VoteReceiver implementation

[Copilot]

Two test failures in VoteReceiverTest were caused by the test helper method processV2Vote() not implementing the same validation logic as the production VoteReceiver class.

Changes

Added missing validation steps:

• Validate outer JSON fields (payload, signature) before parsing inner payload
• Decode Base64 signature to catch malformed signatures early

Before:

public Vote processV2Vote(String jsonPayload) throws Exception {
    JsonObject outer = gson.fromJson(jsonPayload, JsonObject.class);
    String payload = outer.get("payload").getAsString();  // No validation
    JsonObject inner = gson.fromJson(payload, JsonObject.class);
    if (!inner.has("challenge")) {  // Checks inner field first
        throw new Exception("Vote payload missing challenge field.");
    }
    // ...
}

After:

public Vote processV2Vote(String jsonPayload) throws Exception {
    JsonObject outer = gson.fromJson(jsonPayload, JsonObject.class);
    
    if (!outer.has("payload")) {
        throw new Exception("Invalid vote format: Missing required 'payload' field...");
    }
    if (!outer.has("signature")) {
        throw new Exception("Invalid vote format: Missing required 'signature' field...");
    }
    
    String sigHash = outer.get("signature").getAsString();
    try {
        Base64.getDecoder().decode(sigHash);
    } catch (IllegalArgumentException e) {
        throw new Exception("Invalid vote format: Signature is not valid Base64...");
    }
    
    JsonObject inner = gson.fromJson(payload, JsonObject.class);
    // ... validate inner fields
}

This ensures test validation logic matches production behavior and error messages match test assertions.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• hub.spigotmc.org
  • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.12/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.12/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.12 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.12/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/VotifierPlus/VotifierPlus/VotifierPlus org.codehaus.plexus.classworlds.launcher.Launcher test -Dtest=VoteReceiverTest#testV2VoteInvalidBase64Signature -B (dns block)
• libraries.minecraft.net
  • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.12/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.12/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.12 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.12/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/VotifierPlus/VotifierPlus/VotifierPlus org.codehaus.plexus.classworlds.launcher.Launcher test -Dtest=VoteReceiverTest#testV2VoteInvalidBase64Signature -B (dns block)
• nexus.bencodez.com
  • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.12/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.12/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.12 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.12/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/VotifierPlus/VotifierPlus/VotifierPlus org.codehaus.plexus.classworlds.launcher.Launcher test -Dtest=VoteReceiverTest#testV2VoteInvalidBase64Signature -B (dns block)
• nexus.velocitypowered.com
  • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.12/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.12/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.12 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.12/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/VotifierPlus/VotifierPlus/VotifierPlus org.codehaus.plexus.classworlds.launcher.Launcher test -Dtest=VoteReceiverTest#testV2VoteInvalidBase64Signature -B (dns block)
• repo.papermc.io
  • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.12/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.12/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.12 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.12/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/VotifierPlus/VotifierPlus/VotifierPlus org.codehaus.plexus.classworlds.launcher.Launcher test -Dtest=VoteReceiverTest#testV2VoteInvalidBase64Signature -B (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.