[framework] render: merge tessellation points (kill false facet edges in previews) - #111
Merged
Merged
Conversation
…ges draw cq tessellate duplicates vertices along BRep face borders, so vtkFeatureEdges treated every face boundary as an open edge and drew it — lofted/multi-face parts rendered 'faceted' with a line at every station even when the dihedral angle was near zero. Run vtkCleanPolyData (point merging) before the normals/ edge filters: only genuine >35 deg edges and real boundaries render. Purely a preview-quality change; geometry and validation untouched. Signed-off-by: BenchCAD <benchcad@users.noreply.github.com>
bench2 validateset_screw_shaft_collarslotted_din_railspeaker_pole_mount_socketPreviews: the |
miachen0401
approved these changes
Jul 30, 2026
HaozheZhang6
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the "faceted/rough" look of preview renders (maintainer report on #79).
Root cause:
Shape.tessellateduplicates vertices along BRep face borders,so
vtkFeatureEdgessaw every face boundary as an open edge and drew it — aruled loft rendered with a line at every station even where the dihedral angle
is ~1°, and any multi-face surface looked scribbled.
Fix: run
vtkCleanPolyData(point merging) on the tessellated mesh beforethe normals/edge filters in
render_iso. Only true >35° feature edges and realboundaries draw now. Before/after on
stop_bar_tailpiece: station seam linesvanish; genuine edges (slot rims, bore rims, tab steps) stay crisp.
Preview-quality only — geometry, validate gates, and hashes untouched (the mesh
used for geometry hashing in validate is unchanged; this filter lives in the
render path).