[family] single_friction_bearing_universal_joint: DIN 808 EG friction-bearing universal joint - #69
Open
sunzhenchuan007 wants to merge 1 commit into
Conversation
Signed-off-by: Zane <sunzhenchuan@mail.ustc.edu.cn>
|
Welcome, and thanks for the family PR! Three things that answer most questions:
中文:红 ✗ 点 Details 或看 validate 报告评论;本地 |
bench2 validatesingle_friction_bearing_universal_jointPreviews: the |
sunzhenchuan007
marked this pull request as ready for review
July 28, 2026 13:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Family
single_friction_bearing_universal_jointEG— steel, single-jointed universal joint with friction bearingReference (Issue #61 — JW Winco DIN 808 EG)
The official engineering drawing, product photograph, metric catalog table, and source links are recorded in #61. This PR implements only the single-jointed
EGform; it does not include the double-jointedDGform.Generated — benchmark views (what the model sees)
Generated — easy / medium / hard samples
Extremes — smallest & largest sampled instances
Distinct parts and assembly
preview_parts.pnggives four views for each distinct part type. The congruent input/output yoke is shown once (quantity 2), the cross once (quantity 1), followed by assembly highlight views.How it's parameterized
catalog_rowselects exactly one of the 19 official JW Winco metric rows.refine()copies the full coupled row —d1,d2,s,l1,l3, andt— without interpolation or cross-row mixing.Both ends always use the same selected treatment:
bandt2values are coupled to the boreThe output yoke is a rigidly transformed instance of the same yoke geometry as the input. The static pose preserves centered, perpendicular trunnion axes while
joint_anglevaries from 0° to 45°.First-version scope excludes
DG,l2,l4, a second cross, unequal/inch bores, needle-bearing and stainless variants, shafts, and protective boots.Components and assembly
build()returns acq.Assemblywith stable component names:input_yokeoutput_yokecrossfamily.jsondeclares"solids": 3;components[].quantitysums to 3 and matches the three Assembly entities. Each component is built independently.No exploded sequence or assembly arrows are claimed because the reviewed public evidence does not dimension the omitted pins, sleeves, caps, or retainers.
Notes for review
NOTES.mdrecords:l1 = 2*l3relationship;proportiongeometry;Fork-eye, cross-arm, root-overlap, and internal-clearance dimensions not published in the reviewed sources are honestly labeled
proportionrather than presented as DIN or manufacturer dimensions.Verification
uv run bench2 validate single_friction_bearing_universal_jointpart.pyandspec.pypassChecklist
uv run bench2 validate single_friction_bearing_universal_jointpasses locally (CI re-runs it).preview.png,preview_views.png, andpreview_extremes.png; the additionalpreview_parts.pngwas also inspected and committed."solids": 3, three stable Assembly entities, and component quantities summing to 3.PARAM_SPEC.sourceand everycheck()constraint cites the JW Winco tables or honestly saysproportion.designs/single_friction_bearing_universal_joint/and contains only allowed family package files.Sources used
proportionfor uncited fork-eye, cross-arm, root-overlap, and clearance geometryDeliberate simplifications
t +1tolerance is not sampled; nominal tabletdefines the shaft-insertion envelope.