Skip to content

[family] safety_swivel_load_ring - #80

Open
sunzhenchuan007 wants to merge 4 commits into
BenchCAD-org:mainfrom
sunzhenchuan007:codex/issue-62-safety-swivel-load-ring
Open

[family] safety_swivel_load_ring#80
sunzhenchuan007 wants to merge 4 commits into
BenchCAD-org:mainfrom
sunzhenchuan007:codex/issue-62-safety-swivel-load-ring

Conversation

@sunzhenchuan007

@sunzhenchuan007 sunzhenchuan007 commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Family

  • Family: safety_swivel_load_ring
  • Closes [family-assembly] safety_swivel_load_ring #62
  • What the part is: A five-component fixed-pose GN 586 safety swivel load-ring assembly with a U-bent obround clevis, vertical bracket axis, bushing, and bolt.

What changed

  • Coupled all geometry and catalog metadata through the five complete GN 586 inch-thread table rows.
  • Added independent builders and stable cq.Assembly names for load_ring, bracket, bushing, bolt, and clevis.
  • Modeled the user-reviewed clevis from one obround-ended thin strip folded into two parallel ears with coaxial holes.
  • Positioned the ring through the clear space between the ears, with its outer bottom at the lower quarter of the total clevis height.
  • Easy and medium retain the complete closed ring. Hard starts from the same closed ring and then subtracts a bottom gap exactly k2 / 2 wide.
  • Kept WLL, lashing force, tightening torque, temperature range, and swivel-envelope dimensions as metadata only; no load certification or numeric motion angle is claimed.
  • Labeled all undimensioned construction choices as proportion.

Previews

Easy / medium / hard

Easy, medium, and hard preview grid

Four benchmark views

Four benchmark views

Minimum and maximum extremes

Minimum and maximum extremes

Components, assembly overview, and sequential highlights

preview_parts.png first gives four standard views of every distinct component,
then the complete assembly overview. Its final five rows retain the full
assembly and highlight load_ring, bracket, bushing, bolt, and clevis
one at a time in stable component order.

Component views, assembly overview, and sequential component highlights

Checklist

  • uv run bench2 validate safety_swivel_load_ring passes locally; easy, medium, and hard each passed 4/4 sampled seeds.
  • I ran uv run bench2 preview safety_swivel_load_ring and inspected all formal renders plus the assembly preview_parts.png.
  • Multi-body declaration is consistent: family.json declares five solids and five one-off components matching the stable Assembly child names.
  • Every PARAM_SPEC.source and every check() constraint cites the GN 586 source or honestly says proportion; nothing is presented as an invented standard dimension.
  • The PR touches only designs/safety_swivel_load_ring/ and contains only CI-whitelisted package files; no PDF, research attachment, tmp/, cache, or CQ-editor helper script is included.
  • Commits c077b8e, b19fd25, and 50abd54 are DCO-signed.
  • AI-assisted: I reviewed the generated geometry and constraints, including the final CQ-editor placement and component-by-component assembly highlights, and stand behind this contribution.

Sources used

  • JW Winco GN 586 official product page linked from Issue [family-assembly] safety_swivel_load_ring #62.
  • JW Winco GN 586 official 586.pdf and the issue's official table/image attachments.
  • The five printed inch-thread catalog rows are preserved as indivisible row selections.

Verification

  • bench2 validate: PASS, five non-degenerate solids per instance, all five catalog rows covered.
  • bench2 preview: easy/medium/hard, four benchmark views, and min/max renders generated and inspected.
  • Ruff: passed for part.py and spec.py.
  • Fixed-assembly audit: 20 combinations (five catalog rows × two RFID states × two ring-gap states), zero pairwise volumetric intersections and exact lower-quarter ring placement.
  • Local reproduction of the family-pr-checks package whitelist found zero violations.
  • preview_parts.png preserves all five independent component views, the complete assembly overview, and sequential highlights of all five stable components.

Signed-off-by: Zane <sunzhenchuan@mail.ustc.edu.cn>
@github-actions

Copy link
Copy Markdown

Welcome, and thanks for the family PR! Three things that answer most questions:

  • No checks running? A maintainer must click Approve workflows once for your first PR — pending, not ignored.
  • Red gate? The message tells you the fix: click Details, or read the bench2 validate report comment posted after each run. Reproduce locally with uv sync && uv run bench2 validate <family> (debug help).
  • Scope: designs/<family>/ holds only the package files (reference drawings/photos go in the family issue), and the PR checklist must be fully ticked. Not done yet? Mark the PR as a Draft.

中文:红 ✗ 点 Details 或看 validate 报告评论;本地 uv run bench2 validate <family> 复现;参考图放 issue 不放 PR;没做完用 Draft。入门 → GETTING_STARTED.zh

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown

bench2 validate

safety_swivel_load_ring

  ✓ family.json: keys + base_plane valid
  ✓ pieces: build(16 params) + PARAM_SPEC + check present
  ✓ PARAM_SPEC: 21 params, all entries complete
  ✓ easy: 4/4 seeds sample+check+build+execute clean
  ✓ medium: 4/4 seeds sample+check+build+execute clean
  ✓ hard: 4/4 seeds sample+check+build+execute clean
  ✓ coverage: catalog_row reaches all 5 declared values (standard table fully covered)
  ✓ difficulty separation: difficulties produce distinct programs
  ✓ geometry novelty: 7/12 unique shapes (42% duplicate)
  ✓ solids: every instance non-degenerate, 5 solid(s) each (declares solids=5)
PASS — designs/safety_swivel_load_ring

Previews: the previews artifact on this run.

@sunzhenchuan007
sunzhenchuan007 marked this pull request as ready for review July 28, 2026 13:09
Signed-off-by: Zane <sunzhenchuan@mail.ustc.edu.cn>
@sunzhenchuan007
sunzhenchuan007 marked this pull request as draft July 28, 2026 13:27
Signed-off-by: Zane <sunzhenchuan@mail.ustc.edu.cn>
@sunzhenchuan007
sunzhenchuan007 marked this pull request as ready for review July 28, 2026 13:49
@HaozheZhang6

Copy link
Copy Markdown
Collaborator

please copy the ref img from issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[family-assembly] safety_swivel_load_ring

3 participants