[framework] add reproducible assembly preview tooling - #96
Draft
sunzhenchuan007 wants to merge 1 commit into
Draft
[framework] add reproducible assembly preview tooling#96sunzhenchuan007 wants to merge 1 commit into
sunzhenchuan007 wants to merge 1 commit into
Conversation
Signed-off-by: Zane <sunzhenchuan@mail.ustc.edu.cn>
bench2 validateset_screw_shaft_collarslotted_din_railspeaker_pole_mount_socketPreviews: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
uv run bench2 preview-parts <family>for namedcq.Assemblyfamilies;bench2 preview <family>generate the same component artifact automatically for Assemblies;Locationtransforms and render separate VTK actors with correct depth occlusion;family.jsoncomponent names, quantities, andsolidsconsistency before rendering;--per-instancefor one-at-a-time highlighting;Why
Assembly families currently need family-specific scripts to build
preview_parts.png. The existing STEP path folds an Assembly into a Compound and loses component names, so it cannot reproducibly produce semantic component four-views and highlight rows for unrelated families.User impact
Contributors can now run one framework command. The output is deterministic
designs/<family>/preview_parts.png: component four-views, full assembly overview, then metadata-ordered red-on-gray highlights. Invalid or unnamed Assembly metadata fails clearly instead of producing a misleading image.Validation
bench2 preview-parts safety_swivel_load_ringpassDA4DDA3E93CB42AF940267030C6A4D648DD6845EEDC8BC55A408220EAF986E27git diff --check: passNo family source, preview PNG, temporary renderer, PDF, or research attachment is included in this PR.
Closes #95