Skip to content

Refactor/separation of concerns consolidation - #194

Draft
fibenacci wants to merge 2 commits into
BentBr:mainfrom
fibenacci:refactor/separation-of-concerns-consolidation
Draft

Refactor/separation of concerns consolidation#194
fibenacci wants to merge 2 commits into
BentBr:mainfrom
fibenacci:refactor/separation-of-concerns-consolidation

Conversation

@fibenacci

Copy link
Copy Markdown
Collaborator

Also not 100% ready state. have to adjust styling in navigation and merge the current master state into this branch.
I will send you a separate comment when it's ready to review

ü adjust vit.config.ts  to iterate thru shared an module folders
@BentBr BentBr added the wip label Apr 21, 2026
@fibenacci
fibenacci marked this pull request as draft April 21, 2026 13:04
@BentBr

BentBr commented Apr 21, 2026

Copy link
Copy Markdown
Owner

I see issues.

  • why aren't you are using .vue components anymore?
  • The entire refactor is hard to follow. It's even not really possible (without a lot of time) to evaluate if all tests still exist and do properly run.
  • I see removed features like the mobile banner (which is needed as a hint to the users)

@fibenacci

fibenacci commented Apr 27, 2026

Copy link
Copy Markdown
Collaborator Author

@BentBr

  • i wrote a centralized vue file registration 834dba6, that combines ts, css und html files to a single vue file. The main reason is just more structure for any component and avoid reading god object files.
  • i know this kind of refactor is a big commit (doesn't really follow devops core priniple), but in this case i think this is really necessary to get much more clearly overview about all available components
  • the mobile banner stil exists. it'S just a shared component now
image

@fibenacci

Copy link
Copy Markdown
Collaborator Author

For now we have to pause this PR, because of the outbox implementation. In my opinion the outbox implementations has more priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants