lite_description: rename ros2_control plugin to humanoid_control_robstride#5
Merged
Conversation
…trol_robstride Follows the bar_* -> humanoid_control_* series rename. The real-hardware ros2_control plugin for Robstride actuators is now registered as humanoid_control_robstride/RobstrideSystem (was bar_robstride/RobstrideSystem). Updated the generator input (cad/ros2_control.json) and the regenerated xacro for both lite_dummy and lite_bimanual; pytest confirms the committed xacro still matches the generator. The bar_ros2 repo / bar_buildfarm refs are left as-is (repo/channel rename deferred). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The hybrid ros2_control emitter (urdf_to_xacro.py) hardcoded "bar_sito/SitoSystem" in the Sito-joint comment, so regenerated prime xacro always carried the old name regardless of the json plugin value. Rename to humanoid_control_sito to match the bar_* -> humanoid_control_* series rename. Lite robots have no Sito joints, so this is inert for lite_description's own artifacts (1376 pytest pass); it makes future prime_description regenerations emit the new name. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
6d855a7 to
297cc80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downstream consumer update for the
bar_* → humanoid_control_*series rename (humanoid_control / formerly bar_ros2, PR #8).The real-hardware ros2_control plugin is now
humanoid_control_robstride/RobstrideSystem(wasbar_robstride/RobstrideSystem). Updated the generator inputcad/ros2_control.jsonand the regenerated*.ros2_control.xacrofor lite_dummy and lite_bimanual;pytest(873 passed) confirms the committed xacro still matches the generator.The plugin name is a passthrough string, so this is independent of PR #8's build — it can land on its own.
bar_ros2/bar_buildfarmreferences left as-is (repo/channel rename deferred).🤖 Generated with Claude Code