Skip to content

fix: Pin environment versions#103

Closed
juanfonsecaLS1 wants to merge 3 commits intoBikeNetKit:mainfrom
juanfonsecaLS1:fix-env-pins
Closed

fix: Pin environment versions#103
juanfonsecaLS1 wants to merge 3 commits intoBikeNetKit:mainfrom
juanfonsecaLS1:fix-env-pins

Conversation

@juanfonsecaLS1
Copy link
Copy Markdown
Collaborator

This fixes #102 by making versions explicit in the environment files

@juanfonsecaLS1 juanfonsecaLS1 marked this pull request as ready for review March 4, 2026 13:41
@cbueth cbueth self-requested a review March 4, 2026 16:44
@cbueth
Copy link
Copy Markdown
Collaborator

cbueth commented Mar 5, 2026

Thanks @juanfonsecaLS1 for opening the pull request. Looking at the pipeline I see there are still few tests failing.
Maybe you can reproduce the fails locally and either change the version pins or the code itself.

@juanfonsecaLS1
Copy link
Copy Markdown
Collaborator Author

juanfonsecaLS1 commented Mar 5, 2026

It seems that everything works fine with Python = 3.10. I will just pin that version for the moment.

I will open a different PR with the updated code to ensure the compatibility with the current latest Python/NumPy versions, what do you think @cbueth?

@cbueth
Copy link
Copy Markdown
Collaborator

cbueth commented Mar 5, 2026

That's a good approach, so this PR is rather a quick fix and the other will probably need to add few more changes. Thanks for the suggestion!

@cbueth cbueth changed the title fix environment versions fix: pin environment versions Mar 5, 2026
@cbueth cbueth changed the title fix: pin environment versions fix: Pin environment versions Mar 5, 2026
@juanfonsecaLS1
Copy link
Copy Markdown
Collaborator Author

The quick patch is ready. I did not realise that your testing workflow would fail, since it runs the tests for the three versions. I did not want to change your testing set-up though.

@juanfonsecaLS1
Copy link
Copy Markdown
Collaborator Author

Just checking the pyproject.toml, I think I would rather fix the code than just limiting the python version, this to avoid any further conflicts with the classifiers (currently including 3.10, 3.11 and 3.12.

@cbueth
Copy link
Copy Markdown
Collaborator

cbueth commented Mar 5, 2026

Yes, that was to be expected and not too bad. But I see you're motivated for the fixes 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

np.sum(generator) in calculate_coverage fails with NumPy ≥ 2.0

2 participants