Use config of bulk service manager for its operations#172
Open
markusheiden wants to merge 15 commits intoBingAds:mainfrom
Open
Use config of bulk service manager for its operations#172markusheiden wants to merge 15 commits intoBingAds:mainfrom
markusheiden wants to merge 15 commits intoBingAds:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bulk service manager can be configured in various ways. Some of them (e.g. the HTTP file service) won't always be passed to the operations. This PR changes that.
Use case:
We are using NAT. Thus creating and closing HTTP connection to the same destination at a very fast pace leads to resource problems.
This MR allows using one HTTP file service for all operations of the service managers. Thus one could use one connection pool for all HTTP requests of these. This avoids creating and closing connections caused by many HTTP file service instances used for one HTTP request only like done before.